Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(#673): migrate to AuthJS #818

Merged
merged 12 commits into from
Jul 25, 2024
Merged

feat(#673): migrate to AuthJS #818

merged 12 commits into from
Jul 25, 2024

Conversation

phoenix-ru
Copy link
Collaborator

@phoenix-ru phoenix-ru commented Jul 18, 2024 •
edited by zoey-kaiser
Loading

🔗 Linked issue

Closes #673

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

BracketJohn
BracketJohn reviewed Jul 19, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
BracketJohn
BracketJohn reviewed Jul 19, 2024
View reviewed changes
Copy link
Contributor

@BracketJohn BracketJohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Love how @auth takes over most of the server-side authjs-specific now, so that we can focus on the nuxt-app and server-specific logic 🚀

src/runtime/server/services/authjs/nuxtAuthHandler.ts Outdated Show resolved Hide resolved
This was referenced Jul 19, 2024
Closed
Closed
@zoey-kaiser zoey-kaiser changed the title feat(#673): migrate to AuthJs feat(#673): migrate to AuthJS Jul 19, 2024
@zoey-kaiser zoey-kaiser mentioned this pull request Jul 19, 2024
Open
@zoey-kaiser zoey-kaiser added next provider-authjs An issue with the authjs provider breaking-change A change will changes that require at least a minor release. and removed next labels Jul 19, 2024
@phoenix-ru phoenix-ru mentioned this pull request Jul 25, 2024
Open
@phoenix-ru phoenix-ru changed the base branch from main to next July 25, 2024 12:21
@zoey-kaiser zoey-kaiser merged commit 8d6538d into next Jul 25, 2024
5 checks passed
@zoey-kaiser zoey-kaiser deleted the feature/authjs-migration branch July 25, 2024 12:39
This was referenced Aug 8, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BracketJohn BracketJohn BracketJohn left review comments

@zoey-kaiser zoey-kaiser zoey-kaiser approved these changes

Assignees
No one assigned
Labels
1.x breaking-change A change will changes that require at least a minor release. provider-authjs An issue with the authjs provider
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migration to authjs 🚀
3 participants
@phoenix-ru @BracketJohn @zoey-kaiser