fix: add attribute type="button" at insert-command component to prevent form submit (#564) #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @vpikachu Thanks for the PR. In the Issue few more areas are mentioned, can you cover that too? #564 (comment) |
|
Hi @sibiraj-s ! This PR covers all mentioned areas (horizontal_rule and format_clear) ;) |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in the thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Breaking Changes?
Checklist
Describe Your Changes
When ngx-editor used inside form and user click on 'Clear Formatting' button this leads to form submit. Required to add type='button' attribute to button of insert-command component.
Does this PR affects any existing issues?
fixes #564