feat: allow pass in component prefix #943
Open
+92
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RayGuo-ergou |
|
Hi @shufo , just friendly pinging to see if you have a chance to review this PR. |
|
@RayGuo-ergou |
|
I would like this fix too! I just ran into this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a new option
componentPrefixfor html attr format.Related Issue
closes #942 closes #944
Motivation and Context
Due to currently only prefix of
x-orlivewire:treat as custom component and format html attr differently, thus for new libs likefluxwhich uses prefix offlux:. The result of the format will cause a syntex error. e.g.:key="$foo - > bar"How Has This Been Tested?
Both cli and formatter test cases added.
Screenshots (if appropriate):