Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🎸 add option --no-trailing-comma-php #858

Merged
merged 1 commit into from
Sep 10, 2023

Conversation

shufo
Copy link
Owner

@shufo shufo commented Sep 10, 2023

Description

This PR adds option --no-trailing-comma-php.
If set to true, no trailing commas are printed for php expression.',

Related Issue

Motivation and Context

PHP version below 7.2 can't recognize trailing comma on php expression. So we should support trailingCommaPHP option in @prettier/plugin-php for backward compatibility.

How Has This Been Tested?

see tests

@codecov
Copy link

codecov bot commented Sep 10, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.46% 🎉

Comparison is base (0bbed21) 78.53% compared to head (24c59b0) 79.00%.
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #858      +/-   ##
==========================================
+ Coverage   78.53%   79.00%   +0.46%     
==========================================
  Files          16       16              
  Lines        1724     1724              
  Branches      408      408              
==========================================
+ Hits         1354     1362       +8     
+ Misses        358      330      -28     
- Partials       12       32      +20     
Files Changed Coverage Δ
src/formatter.ts 90.30% <ø> (+0.43%) ⬆️
src/main.ts 32.28% <ø> (+1.34%) ⬆️
src/runtimeConfig.ts 57.14% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shufo shufo merged commit 9338973 into main Sep 10, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant