Don't assume project in context. #73
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+1238
to
+1240
| project_id = None | ||
| if self._app.context.project: | ||
| project_id = self._app.context.project["id"] |
There was a problem hiding this comment.
I see this can be changed to a simplified version such as:
Suggested change
| project_id = None | |
| if self._app.context.project: | |
| project_id = self._app.context.project["id"] | |
| project_id = self._app.context.project.get("id") |
However, will bring other unexpected errors having a project_id as None? Can you share the log lines when the panel breaks, please?
Merging in latest from ShotGrid
Latest from Autodesk
Pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assuming that the current context has a project breaks the panel from loading in ShotGrid Desktop using this example.