Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SG-21701 Replace instances of Shotgun strings in .py files in all tk-… #142

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

zamu5
Copy link

@zamu5 zamu5 commented Mar 26, 2021

…* repos with "SG"

@zamu5 zamu5 requested a review from thebeeland March 26, 2021 22:17
Copy link

@hound hound bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 5, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

Copy link

@hound hound bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 5, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

Copy link

@hound hound bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 5, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

Copy link

@hound hound bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 5, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

Copy link

@hound hound bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 5, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

Copy link

@hound hound bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 5, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

@codecov
Copy link

codecov bot commented Mar 26, 2021

Codecov Report

Merging #142 (f340f26) into master (fdd309d) will decrease coverage by 43.02%.
The diff coverage is 16.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #142       +/-   ##
===========================================
- Coverage   82.15%   39.13%   -43.03%     
===========================================
  Files          61       61               
  Lines        4730     4730               
===========================================
- Hits         3886     1851     -2035     
- Misses        844     2879     +2035     
Impacted Files Coverage Δ
...ti_publish2/api/plugins/publish_plugin_instance.py 92.85% <0.00%> (ø)
python/tk_multi_publish2/dialog.py 0.00% <0.00%> (-80.03%) ⬇️
...ti_publish2/progress/ui/progress_details_widget.py 0.00% <0.00%> (-100.00%) ⬇️
python/tk_multi_publish2/ui/dialog.py 0.00% <0.00%> (-100.00%) ⬇️
hooks/publish_file.py 59.29% <100.00%> (-2.22%) ⬇️
python/tk_multi_publish2/qtwidgets.py 0.00% <0.00%> (-100.00%) ⬇️
python/tk_multi_publish2/progress/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
python/tk_multi_publish2/ui/settings_widget.py 0.00% <0.00%> (-100.00%) ⬇️
python/tk_multi_publish2/ui/summary_overlay.py 0.00% <0.00%> (-100.00%) ⬇️
python/tk_multi_publish2/progress_status_label.py 0.00% <0.00%> (-100.00%) ⬇️
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdd309d...f340f26. Read the comment docs.

tests/test_gui.py Outdated Show resolved Hide resolved
tests/test_gui.py Outdated Show resolved Hide resolved
tests/test_gui.py Outdated Show resolved Hide resolved
tests/test_gui.py Outdated Show resolved Hide resolved
tests/test_gui.py Outdated Show resolved Hide resolved
app_dialog.root["collected items tree"].outlineitems[
"Publish to Shotgun with items"
][1].mouseClick()
app_dialog.root["collected items tree"].outlineitems["Publish to Shotgun with items"][
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Black would make changes.

@zamu5 zamu5 requested a review from eshokrgozar May 12, 2021 18:16
Copy link
Contributor

@eshokrgozar eshokrgozar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how deep you were asked to take this so let me know if these were left out on purpose. But there are a few Shotgun mentions that haven't been changed. Here are some examples (there are more):

return "Publish to Shotgun"

"description": "Upload content to Shotgun?",

- name: Publish to Shotgun

There are also logger messages mentioning Shotgun. Are we leaving these for now? Again, just an example:

self.logger.warn(

Lastly. The tests are failing on this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants