-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SG-21701 Replace instances of Shotgun strings in .py files in all tk-… #142
base: master
Are you sure you want to change the base?
Conversation
…* repos with "SG"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some files could not be reviewed due to errors:
Traceback (most recent call last):
Traceback (most recent call last): File "/home/linters/.local/bin/flake8", line 5, in from flake8.main.cli import main ModuleNotFoundError: No module named 'flake8'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some files could not be reviewed due to errors:
Traceback (most recent call last):
Traceback (most recent call last): File "/home/linters/.local/bin/flake8", line 5, in from flake8.main.cli import main ModuleNotFoundError: No module named 'flake8'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some files could not be reviewed due to errors:
Traceback (most recent call last):
Traceback (most recent call last): File "/home/linters/.local/bin/flake8", line 5, in from flake8.main.cli import main ModuleNotFoundError: No module named 'flake8'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some files could not be reviewed due to errors:
Traceback (most recent call last):
Traceback (most recent call last): File "/home/linters/.local/bin/flake8", line 5, in from flake8.main.cli import main ModuleNotFoundError: No module named 'flake8'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some files could not be reviewed due to errors:
Traceback (most recent call last):
Traceback (most recent call last): File "/home/linters/.local/bin/flake8", line 5, in from flake8.main.cli import main ModuleNotFoundError: No module named 'flake8'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some files could not be reviewed due to errors:
Traceback (most recent call last):
Traceback (most recent call last): File "/home/linters/.local/bin/flake8", line 5, in from flake8.main.cli import main ModuleNotFoundError: No module named 'flake8'
Codecov Report
@@ Coverage Diff @@
## master #142 +/- ##
===========================================
- Coverage 82.15% 39.13% -43.03%
===========================================
Files 61 61
Lines 4730 4730
===========================================
- Hits 3886 1851 -2035
- Misses 844 2879 +2035
Continue to review full report at Codecov.
|
app_dialog.root["collected items tree"].outlineitems[ | ||
"Publish to Shotgun with items" | ||
][1].mouseClick() | ||
app_dialog.root["collected items tree"].outlineitems["Publish to Shotgun with items"][ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Black would make changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how deep you were asked to take this so let me know if these were left out on purpose. But there are a few Shotgun
mentions that haven't been changed. Here are some examples (there are more):
tk-multi-publish2/hooks/publish_file.py
Line 133 in f340f26
return "Publish to Shotgun" |
tk-multi-publish2/hooks/upload_version.py
Line 97 in f340f26
"description": "Upload content to Shotgun?", |
Line 82 in f340f26
- name: Publish to Shotgun |
There are also logger messages mentioning Shotgun
. Are we leaving these for now? Again, just an example:
tk-multi-publish2/hooks/publish_file.py
Line 336 in f340f26
self.logger.warn( |
Lastly. The tests are failing on this PR
…* repos with "SG"