Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SG-26915 Formalize the end of CentOS support #49

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

SG-26915 Formalize the end of CentOS support #49

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a15ef0
WIP
julien-lang Nov 8, 2024
fd22ca9
Make logic available to all OS
carlos-villavicencio-adsk Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 4 additions & 16 deletions python/setup_project/progress_page.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,22 +154,10 @@ def _process_new_logged_info(self):

def progress_callback(self, chapter, progress):
# Since a thread could be calling this make sure we are doing GUI work on the main thread.
# On Windows and CentOS, we have stability issues related to the async main thread executor,
# so we're not going to rely on it here. Instead, we track the chapter and progress values
# and we let the QTimer we have running find them and set them from the main thread without
# the need for any direct cross-thread communication.
#
# NOTE: OSX is the exception. We don't have stability issues there related to the main thread
# execution, and we get MUCH better progress-bar performance/UX when we skip using the
# QTimer approach to keeping it updated.
if sgtk.util.is_macos():
engine = sgtk.platform.current_engine()
engine.async_execute_in_main_thread(
self.__progress_on_main_thread, chapter, progress
)
else:
self._chapter = chapter
self._progress = progress
engine = sgtk.platform.current_engine()
engine.async_execute_in_main_thread(
self.__progress_on_main_thread, chapter, progress
)

def __progress_on_main_thread(self, chapter, progress):
# update the progress display
Expand Down