Skip to content

Commit

Permalink
chore: add macOS artifacts to artifact proxy (#2662)
Browse files Browse the repository at this point in the history
  • Loading branch information
bryanoltman authored Dec 7, 2024
1 parent a51abef commit 467e547
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 5 deletions.
7 changes: 6 additions & 1 deletion packages/artifact_proxy/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,12 @@ poison the cache of your main Flutter checkout.

## Updating config.dart

If run into 404s when fetching artifacts, you may need to update the artifact list in `config.dart`.
If run into 404s when fetching artifacts, ensure that the expected manifest
exists at
https://storage.googleapis.com/download.shorebird.dev/shorebird/$engineRevision/artifacts_manifest.yaml.

If it does, you may need to update the artifact list in `config.dart` and, if
the artifact is one we're providing, add it in `tool/generate_manifest.sh`

To do so, you will need to determine the artifact URLs. Follow these steps:

Expand Down
8 changes: 4 additions & 4 deletions packages/artifact_proxy/lib/config.dart
Original file line number Diff line number Diff line change
Expand Up @@ -39,14 +39,14 @@ final engineArtifactPatterns = {
r'flutter_infra_release\/flutter\/(.*)\/darwin-x64\/font-subset\.zip',
r'flutter_infra_release\/flutter\/(.*)\/darwin-x64\/FlutterMacOS.framework\.zip',
r'flutter_infra_release\/flutter\/(.*)\/darwin-x64\/artifacts\.zip',
r'flutter_infra_release\/flutter\/(.*)\/darwin-x64-release\/gen_snapshot\.zip',
r'flutter_infra_release\/flutter\/(.*)\/darwin-x64-release\/FlutterMacOS.framework\.zip',
r'flutter_infra_release\/flutter\/(.*)\/darwin-x64-release\/artifacts\.zip',
r'flutter_infra_release\/flutter\/(.*)\/darwin-x64-release\/framework\.zip',
r'flutter_infra_release\/flutter\/(.*)\/darwin-x64-profile\/gen_snapshot\.zip',
r'flutter_infra_release\/flutter\/(.*)\/darwin-x64-profile\/FlutterMacOS.framework\.zip',
r'flutter_infra_release\/flutter\/(.*)\/darwin-x64-profile\/artifacts\.zip',
r'flutter_infra_release\/flutter\/(.*)\/darwin-x64-profile\/framework\.zip',
r'flutter_infra_release\/flutter\/(.*)\/darwin-x64-profile\/gen_snapshot\.zip',
r'flutter_infra_release\/flutter\/(.*)\/darwin-x64-release\/artifacts\.zip',
r'flutter_infra_release\/flutter\/(.*)\/darwin-x64-release\/framework\.zip',
r'flutter_infra_release\/flutter\/(.*)\/darwin-x64-release\/gen_snapshot\.zip',
r'flutter_infra_release\/flutter\/(.*)\/darwin-arm64\/font-subset\.zip',
r'flutter_infra_release\/flutter\/(.*)\/darwin-arm64\/artifacts\.zip',
r'flutter_infra_release\/flutter\/(.*)\/dart-sdk-windows-x64\.zip',
Expand Down
5 changes: 5 additions & 0 deletions packages/artifact_proxy/tool/generate_manifest.sh
Original file line number Diff line number Diff line change
Expand Up @@ -71,3 +71,8 @@ artifact_overrides:
# Includes unified Flutter.framework for device and simulator (debug)
- flutter_infra_release/flutter/\$engine/ios-release/artifacts.zip
- flutter_infra_release/flutter/\$engine/ios-release/Flutter.dSYM.zip
# macOS release artifacts
- flutter_infra_release/flutter/\$engine/darwin-x64-release/artifacts.zip
- flutter_infra_release/flutter/\$engine/darwin-x64-release/framework.zip
- flutter_infra_release/flutter/\$engine/darwin-x64-release/gen_snapshot.zip

0 comments on commit 467e547

Please sign in to comment.