Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add macOS flavors example #16

Merged
merged 2 commits into from
Jan 17, 2025
Merged

feat: add macOS flavors example #16

merged 2 commits into from
Jan 17, 2025

Conversation

bryanoltman
Copy link
Contributor

Description

Adds a macOS example.

Depends on shorebirdtech/shorebird#2780

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 🧪 Tests
  • 📝 Documentation
  • 🗑️ Chore

eseidel
eseidel approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@eseidel eseidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is just adding/upgrading the mac target in our flavors example, correct?

@bryanoltman
Copy link
Contributor Author

So this is just adding/upgrading the mac target in our flavors example, correct?

Adding, yep!

@bryanoltman bryanoltman merged commit 5259162 into main Jan 17, 2025
4 checks passed
@bryanoltman bryanoltman deleted the bo/macos-flavors branch January 17, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eseidel eseidel eseidel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bryanoltman @eseidel