Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(progressive_rollout): eliminate non-deterministic behavior #15

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

felangel
Copy link
Contributor

@felangel felangel commented Nov 15, 2024

Description

  • fix(progress_rollout): eliminate non-deterministic behavior
    • previously the groupNumber was nullable and the update behavior would be different depending on the timing of the SharedPreferences read. If the read was fast, the update would use the correct track -- otherwise it would default to stable. This change eliminates that case and makes the groupNumber non-nullable while also reducing the number of times SharedPreferences is read to just a single time when the app is run.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 🧪 Tests
  • 📝 Documentation
  • 🗑️ Chore

@felangel felangel self-assigned this Nov 15, 2024
@felangel felangel changed the title fix(progress_rollout): eliminate non-deterministic behavior fix(progressive_rollout): eliminate non-deterministic behavior Nov 15, 2024
Copy link
Contributor

@eseidel eseidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bryanoltman should probably review since he wrote this, but lgtm.

@felangel felangel merged commit 4af619e into main Nov 15, 2024
4 checks passed
@felangel felangel deleted the refactor/group-number-race-condition branch November 15, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants