Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add runs-on magic cache #19

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Conversation

mkraeml
Copy link
Contributor

@mkraeml mkraeml commented Jan 10, 2025

In v2.6.3 of runs-on they introduced a new feature named "Magic Cache". It redirects the cache calls for actions like actions/cache and docker/build-push-action to a S3 bucket, which is faster for our private runners.
If the action is run on a official runner, it just does nothing, so it is safe to be called on both runner types.

In v2.6.3 of runs-on they introduced a new feature named "Magic Cache". It redirects the cache calls for actions like `actions/cache` and `docker/build-push-action` to a S3 bucket, which is faster for our private runners.
If the action is run on a official runner, it just does nothing, so it is safe to be called on both runner types.
@mkraeml mkraeml merged commit 3e33389 into main Jan 10, 2025
8 checks passed
@shyim
Copy link
Member

shyim commented Jan 10, 2025

why do we add it here? this should be part of shopware itself. nobody else than us needs this

@pweyck
Copy link
Contributor

pweyck commented Jan 10, 2025

why do we add it here? this should be part of shopware itself. nobody else than us needs this

It's a noop on standard runner.

Maybe could define an internal setup-shopware instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants