feat: make ShopRepository generic

src/AppLifecycle.php

@@ -27,6 +27,9 @@
  */
 class AppLifecycle
 {
+    /**
+     * @param ShopRepositoryInterface<ShopInterface> $shopRepository
+     */
     public function __construct(
         private readonly RegistrationService $registrationService,
         private readonly ShopResolver $shopResolver,

src/Registration/RegistrationService.php

@@ -19,10 +19,14 @@
 use Shopware\App\SDK\Exception\ShopNotFoundException;
 use Shopware\App\SDK\Exception\SignatureNotFoundException;
 use Shopware\App\SDK\Exception\SignatureInvalidException;
+use Shopware\App\SDK\Shop\ShopInterface;
 use Shopware\App\SDK\Shop\ShopRepositoryInterface;
 
 class RegistrationService
 {
+    /**
+     * @param ShopRepositoryInterface<ShopInterface> $shopRepository
+     */
     public function __construct(
         private readonly AppConfiguration $appConfiguration,
         private readonly ShopRepositoryInterface $shopRepository,

src/Shop/ShopRepositoryInterface.php

@@ -4,14 +4,29 @@
 
 namespace Shopware\App\SDK\Shop;
 
+/**
+ * @template T of ShopInterface
+ */
 interface ShopRepositoryInterface
 {
+    /**
+     * @return T
+     */
     public function createShopStruct(string $shopId, string $shopUrl, string $shopSecret): ShopInterface;
 
+    /**
+     * @param T $shop
+     */
     public function createShop(ShopInterface $shop): void;
 
+    /**
+     * @return T|null
+     */
     public function getShopFromId(string $shopId): ShopInterface|null;
 
+    /**
+     * @param T $shop
+     */
     public function updateShop(ShopInterface $shop): void;
 
     public function deleteShop(string $shopId): void;

src/Shop/ShopResolver.php

@@ -15,6 +15,9 @@
  */
 class ShopResolver
 {
+    /**
+     * @param ShopRepositoryInterface<ShopInterface> $shopRepository
+     */
     public function __construct(private readonly ShopRepositoryInterface $shopRepository, private readonly RequestVerifier $requestVerifier = new RequestVerifier())
     {
     }

src/Test/MockShopRepository.php

@@ -7,10 +7,13 @@
 use Shopware\App\SDK\Shop\ShopInterface;
 use Shopware\App\SDK\Shop\ShopRepositoryInterface;
 
+/**
+ * @implements ShopRepositoryInterface<MockShop>
+ */
 class MockShopRepository implements ShopRepositoryInterface
 {
     /**
-     * @var array<string, ShopInterface>
+     * @var array<string, MockShop>
      */
     public array $shops = [];