using regex to match detector classes directly as appose to iterating #79
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to build a regex, by adding all "look_for", Example:-
if we add all "look_for" of "os"(known_type)
"Windows Phone OS|Windows Phone|Symbian|SymbianOS|CrOS|PlayStation|PLAYSTATION|Windows|Series40|iPhone|iPad|BlackBerry|Macintosh|Linux"
Then with this regex we can jump to respective "detector" class on which we have to run detect as appose to iterating.
some profiling:-
With changes
without changes
So i am actually making it slower overall
But if u run on in a loop of 100000
with changes
without changes
There is difference in this case
This idea, i wanted to try out, code is messy but i can clean it a bit if u see potential in it.
But agree, regex is always a little tricky and error prone.