consider only valid upstreams for response times

sholdee · Jul 8, 2024 · 99aab28 · 99aab28
1 parent 02c5da2
commit 99aab28
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/adguard_exporter.go b/adguard_exporter.go
@@ -234,7 +234,8 @@ func (mc *MetricsCollector) UpdateMetrics(data map[string]interface{}) {
 
     mc.lock.Lock()
     mc.responseTimes = append(mc.responseTimes, TimeValue{Time: currentTime, Value: elapsedMs})
-    if upstream != "unknown" {
+    // Exclude metrics with unknown upstreams
+    if upstream != "unknown" && upstream != "" {
         mc.upstreamResponseTimes[upstream] = append(mc.upstreamResponseTimes[upstream], TimeValue{Time: currentTime, Value: elapsedMs})
     }
     mc.lock.Unlock()
@@ -273,6 +274,9 @@ func (mc *MetricsCollector) ProcessMetrics() {
     }
 
     for upstream, times := range mc.upstreamResponseTimes {
+        if upstream == "unknown" || upstream == "" {
+            continue // Skip processing for unknown upstreams
+        }
         recentTimes := mc.filterRecentTimes(times, cutoffTime)
         if len(recentTimes) > 0 {
             avgUpstreamTime := mc.calculateAverage(recentTimes)