Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print a warning when manually running visit:download-db with no license #1926

Merged

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Nov 23, 2023

Closes #1877

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (cb0bac5) 96.87% compared to head (a3554ea) 96.90%.

Files Patch % Lines
...CLI/src/Command/Visit/DownloadGeoLiteDbCommand.php 92.85% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1926      +/-   ##
=============================================
+ Coverage      96.87%   96.90%   +0.02%     
- Complexity      1331     1333       +2     
=============================================
  Files            247      247              
  Lines           4610     4615       +5     
=============================================
+ Hits            4466     4472       +6     
+ Misses           144      143       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acelaya acelaya merged commit 0511c73 into shlinkio:develop Nov 23, 2023
32 of 33 checks passed
@acelaya acelaya deleted the feature/geolite-download-warn branch November 23, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide some feedback when manually running visit:download-db without license key
1 participant