more phpstan 2.0 stuff

[shish]

Summary by CodeRabbit

• New Features

  • Introduced new event classes: UserBlockBuildingEvent, UserOperationsBuildingEvent, and UserPageBuildingEvent.

• Improvements

  • Enhanced type safety and initialization for user-related events.
  • Improved error handling in the image posting process, providing specific feedback for duplicate images.
  • Streamlined operand extraction in search term processing.

• Bug Fixes

  • Adjusted return values in tag matching to ensure proper array indexing.

• Tests

  • Updated assertions in random image tests for better validation and error handling.

[coderabbitai]

Walkthrough

The changes across multiple files involve modifications to method signatures, logic adjustments, and the introduction of new classes and methods. Key updates include refining type annotations for improved type safety, simplifying operand extraction logic, enhancing error handling in API methods, and updating test assertions for better specificity. Additionally, new event classes related to user operations have been introduced, and some existing methods have had their internal logic modified without changing their signatures.

Changes

File Path	Change Summary
core/imageboard/tag.php	Updated return type of explode method from @return string[] to @return list<string>.
ext/index/events.php	Modified constructor logic in SearchTermParseEvent to simplify operand extraction; no changes to public properties or methods.
ext/ouroboros_api/main.php	Enhanced postIndex to filter non-object entries; updated postCreate to handle duplicate image checks and improved error messaging.
ext/post_tags/main.php	Changed return statement in matches method to return array_values($matches) for reindexing.
ext/random_image/test.php	Modified assertions in testRandom and testPostListBlock methods for improved specificity in testing outcomes.
ext/user/events.php	Initialized $user property to null in UserCreationEvent; added new classes and methods related to user events.
ext/word_filter/main.php	Removed assertion checking if $text is a string in the filter method; overall logic remains unchanged.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant API
    participant Database

    User->>API: Create Post
    API->>Database: Check for duplicate image
    Database-->>API: Return duplicate status
    alt Duplicate found
        API-->>User: Error message for duplicate
    else No duplicate
        API->>Database: Save new post
        Database-->>API: Confirmation
        API-->>User: Post created successfully
    end

Loading

🐰 "In the code, a hop and a skip,
Types are changed, logic's a flip.
New classes sprout, like carrots in rows,
Enhancing the flow, as the rabbit knows!
With each little tweak, our code's in fine shape,
Hooray for the changes, let’s celebrate!" 🥕

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d28f812 and bfe7b2b.

📒 Files selected for processing (7)

• core/imageboard/tag.php (1 hunks)
• ext/index/events.php (1 hunks)
• ext/ouroboros_api/main.php (0 hunks)
• ext/post_tags/main.php (1 hunks)
• ext/random_image/test.php (2 hunks)
• ext/user/events.php (1 hunks)
• ext/word_filter/main.php (0 hunks)

💤 Files with no reviewable changes (2)

• ext/word_filter/main.php
• ext/ouroboros_api/main.php

🚧 Files skipped from review as they are similar to previous changes (5)

• core/imageboard/tag.php
• ext/post_tags/main.php
• ext/random_image/test.php
• ext/index/events.php
• ext/user/events.php

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.