[themes] make a build_tag function which themes can override, see #1328

shish · Dec 13, 2024 · d629a5e · d629a5e
1 parent adac4f4
commit d629a5e
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 5 deletions.
diff --git a/core/themelet.php b/core/themelet.php
@@ -28,6 +28,13 @@ private function get_common(): Themelet
         return self::$common;
     }
 
+    public function build_tag(string $tag): HTMLElement
+    {
+        $c = self::get_common();
+        assert(is_a($c, CommonElementsTheme::class));
+        return $c->build_tag($tag);
+    }
+
     public function build_thumb(Image $image): HTMLElement
     {
         $c = self::get_common();

diff --git a/ext/common_elements/theme.php b/ext/common_elements/theme.php
@@ -10,6 +10,15 @@
 
 class CommonElementsTheme extends Themelet
 {
+    public function build_tag(string $tag): HTMLElement
+    {
+        return A([
+            "href" => search_link([$tag]),
+            "class" => "tag",
+            "title" => "View all posts tagged $tag"
+        ], $tag);
+    }
+
     /**
      * Generic thumbnail code; returns HTML rather than adding
      * a block since thumbs tend to go inside blocks...

diff --git a/ext/post_tags/theme.php b/ext/post_tags/theme.php
@@ -31,11 +31,7 @@ public function get_tag_editor_html(Image $image): HTMLElement
 
         $tag_links = [];
         foreach ($image->get_tag_array() as $tag) {
-            $tag_links[] = A([
-                "href" => search_link([$tag]),
-                "class" => "tag",
-                "title" => "View all posts tagged $tag"
-            ], $tag);
+            $tag_links[] = $this->build_tag($tag);
         }
 
         return SHM_POST_INFO(