[core] fix error in error handling

shish · Jan 11, 2024 · acd3abc · acd3abc
1 parent 36388aa
commit acd3abc
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/core/testcase.php b/core/testcase.php
@@ -208,12 +208,12 @@ protected function assertException(string $type, callable $function): \Exception
                 $exception = $e;
             }
 
-            if(is_a($exception, $type)) {
-                self::assertThat($exception, new \PHPUnit\Framework\Constraint\Exception($type));
-                return $exception;
-            } else {
-                throw $exception;
-            }
+            self::assertThat(
+                $exception,
+                new \PHPUnit\Framework\Constraint\Exception($type),
+                "Expected exception of type $type, but got " . ($exception ? get_class($exception) : "none")
+            );
+            return $exception;
         }
 
         // user things