Small Optimizations #3905
Open
Small Optimizations #3905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hearing muffled anime music in the hangars is culture though. |
|
Pacmans, maybe lathes, also eject contents when deleted and could use tlc too |
|
gottem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Just some miscellaneous optimizations I've slowly been accumulating, centering around yet another rewrite of ImmediateCalculateAdjacentTurfs(). Others include jukeboxes, scrubbers, and lights, and also includes the elimination of a bunch of Destroy() side effects because those suck
Why It's Good For The Game
I don't know if this will actually do too much but every bit helps, and the code quality is hopefully a bit better
Changelog
🆑
fix: Jukeboxes should not leak across virtual Zs anymore
fix: Candles can no longer be used like tiki torches
tweak: Ore silos will now only drop materials when dissasembled or destroyed, instead of any deletion
/:cl: