Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soulifies Backpacks & Duffels #3865

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

Sun-Soaked
Copy link
Member

@Sun-Soaked Sun-Soaked commented Dec 1, 2024

About The Pull Request

Backpacks and Duffel bags can now carry bulky items, and Duffel bags now have more storage space.

Backpacks cannot be opened while worn on your back.
Duffels now cannot be opened unless placed on the ground.

Why It's Good For The Game

This gives satchel/messenger bag's low storage space an upside(access from back), while justifying putting bigger items in storage objects that really should be able to carry them.
Duffel bags are now very well-storage spaced, and can be specialized as a kind of stash bag.

Backpack and duffel bags may need to have even more storage space to compensate, but for now I've been pretty frugal in buffing it.
It's soul. Soon you will understand my vision

Changelog

🆑
balance: Backpacks can now carry Bulky items, but can no longer be accessed while on your back.
balance: Duffel bags can now carry more, but must be placed on the ground to be opened.
/:cl:

take your medicine
@github-actions github-actions bot added the Code change Watch something violently break. label Dec 1, 2024
Sun-Soaked and others added 5 commits December 1, 2024 17:24
technically everything buff but I needed to preserve -some- scaling
@thearbiber
Copy link

The lowered storage for satchels feels a bit worse to play with. The duffels and all that are pretty useful tools now.

@Sun-Soaked
Copy link
Member Author

The lowered storage for satchels feels a bit worse to play with. The duffels and all that are pretty useful tools now.

satchel storage wasn't actually changed. check the changed files

@thgvr
Copy link
Member

thgvr commented Dec 4, 2024

placebo is real

@thearbiber
Copy link

I may have gaslit myself

@SomeguyManperson
Copy link
Contributor

SomeguyManperson commented Dec 4, 2024

it was bc this actually swaps them to use satchel storage size from backpack storage size
placebo is FAKE

@Sun-Soaked
Copy link
Member Author

it was bc this actually swaps them to use satchel storage size from backpack storage size placebo is FAKE

fuck

@Ratvarr
Copy link

Ratvarr commented Dec 5, 2024

image
Need I say more
image
Dufflebags.

@Jedi-Toothpaste
Copy link
Contributor

Jedi-Toothpaste commented Dec 5, 2024

image Need I say more image Dufflebags.

I thought the storage would have been reduced since before duffelbags could only hold four bulky items, but I don't think the amount it could store was changed?

EDIT: ignore me i'm stupid, I think duffels should hold less actually

edit 2: I commented this on the wrong PR but you saw it anyway:
you can take your backpack off, hold the inventory open and re-equip it. Allowing you to take items out without taking it back off

@Sun-Soaked
Copy link
Member Author

image Need I say more image Dufflebags.

top guns should not be tiny size- also duffels have been nerfed since this-
but this is also kind of inevitable as a consequence of Real item sizes

a storage object than can hold 5 bulky items can hold 10 normal ones, or 20 small ones, and so on.
We'll need to do more sanity adjustment to pull a bunch of items up from tiny into small and certain objects from bulky into huge.

This only increased the storage of duffels by 1 bulky item, so this was already pretty much an issue

@Jedi-Toothpaste
Copy link
Contributor

Jedi-Toothpaste commented Dec 6, 2024

followup to my issue from wednesday
You can still keep the inventory open and pull items out of a backpack/duffel
HOWEVER
you can put items back into inventories inside of the bag, for instance, you can put items into a box from the backpack
image
image
image

and of course, you can take it out as the inventory is open already, and furthermore, because the box doesn't do the backpack check, you can shuffle items in and out allowing you to use it like a very crap storage

image

lastly, since the box storage is bigger it's actually viable to do this

@generalthrax
Copy link
Contributor

I have to say, satchel being 4 normal-sized items only feels. Very bad. Like terribly so.

@thearbiber
Copy link

Satchels now hold 4 normal items. This is painful.

@Sun-Soaked
Copy link
Member Author

if anyone figures out what this is or it appears in testing from a specific Thing ingame please let me know bc I can't reproduce it & it's apparently coming by way of like /obj/machinery/examine, and I have no idea how that's happening

image

also fixes potential problem with showing messages to correct mob during storage procs
@generalthrax
Copy link
Contributor

generalthrax commented Dec 8, 2024

Seems duffelbags can no longer be accessed even on the ground. Rations similarly can no longer be opened.

@Sun-Soaked
Copy link
Member Author

Seems duffelbags can no longer be accessed even on the ground. Rations similarly can no longer be opened.

issue with an access_check() refactor I did. should be fine now

@tantspants
Copy link

Backpacks can't be accessed on the ground. It gives the same message as when you try when it's on your back.

bottom text
@randy10122
Copy link
Contributor

hot take: i think the backpack changes are not good for gameplay at all
duffel changes are whatever - theyve always been the Niche Choice in bags
but why change backpacks? the way i see it, the only difference between a backpack and a satchel should be visual. why sacrifice style for changes that, ill be completely honest, i have only heard complaints about?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants