Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vela Industrial Cruiser: 4th Time the charm? #3843

Open
wants to merge 38 commits into
base: master
Choose a base branch
from

Conversation

Erikafox
Copy link
Contributor

About The Pull Request

Adds the Vela Industrial Cruiser, a Minuteman capital ship (Last one I'm doing for a long time) built around mining, mechs, and roleplay.

Screenshots

StrongDMM-2024-11-26 20 12 39
StrongDMM-2024-11-26 20 12 41
dreamseeker_2vNSYmdM5A
dreamseeker_v86d5uuOdN

Crew of 15. Yes I am aware this is absurd. Yes I am aware it will get played very infrequently. Looking For Ship should help.
1x Captain
1x Foreman
1x First Officer
2x Mech Pilots
2x Mechanics
2x Minutemen
1x Doctor
5x Random Guys With Sticks

Light armament
sidearms for officers
2x cm23
1x cm15

Mech Stuff
Functional medbay
Well geared engineering
Sauna

Why It's Good For The Game

frankly this is a vanity project.

Changelog

🆑
add: The Vela-Class industrial cruiser is BACK and WORSE THAN EVER
/:cl:

@Erikafox Erikafox requested review from a team as code owners November 27, 2024 01:37
@github-actions github-actions bot added Map Change Tile placing is hard. Thank you for your service. Sprites A bikeshed full of soulless bikes. Ship Ship successfully tested. labels Nov 27, 2024
@github-actions github-actions bot added the Code change Watch something violently break. label Nov 27, 2024
@thearbiber
Copy link

What if you added crack for the minutemen

@MassiveMen
Copy link
Contributor

What if you. Wanted to go to heaven. But god said. Remap the Vela a fourth time.

@Erikafox
Copy link
Contributor Author

the vela fits a similar niche to stupid overengineered nazi vanity projects. it is stupid. it is overengineered. it is way too big. it doesn't work good. sometimes it just combusts. people keep trying to make it work.

@meemofcourse
Copy link
Contributor

IT'LL WORK THIS TIME

@generalthrax
Copy link
Contributor

Hows the power drain on this ship

@Erikafox
Copy link
Contributor Author

Worthy of the engineering section

@dessysalta
Copy link

Just wanted to say this ship is gorgeous.

Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Nov 29, 2024
@github-actions github-actions bot removed Merge Conflict Use Git Hooks, you're welcome. Sprites A bikeshed full of soulless bikes. labels Dec 2, 2024
Copy link
Contributor

@meemofcourse meemofcourse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imagen
imagen

  • i have to ask. why is there a crate full of soda cans
  • there are two ration crates with no rations in them and three water bottles each

imagen

i do not like these dorms. this is a military-ish ship so it should probably have something more akin to barracks

imagen

i know this is a ridiculous change. but i'm gonna have to ask you to remove one beagle mug from the bridge

imagen

i do not like the perfect spacing between these coffee mugs

imagen

this does not feel like a correct use of platforms

imagen

minor nitpick and you can object but the minuteman outfit popularly uses bulletproof vests, not standard armor vests

imagen

officers get jackboots

imagen

you should avoid mapping stamps that are for a faction itself since that kind of implies the ability to approve stuff on the behalf of the entire faction

imagen

i would probably ask rye if you can use the cm-1

imagen

change the description on this Guy.

imagen

you cannot use wooden logs as fuel for the sauna

imagen

minor nitpick but most of the ship could use some more signaling for where stuff is

i dunno what else i wanna take a nap

@Erikafox
Copy link
Contributor Author

Erikafox commented Dec 5, 2024

  • i have to ask. why is there a crate full of soda cans
  • there are two ration crates with no rations in them and three water bottles each

No vendors on the ship (clip rule), ration crates spawn rations on init

i do not like these dorms. this is a military-ish ship so it should probably have something more akin to barracks

design intent is for a less military design. Less space cops and more "This is military adjacent"

minor nitpick but most of the ship could use some more signaling for where stuff is

I'll put some signs up.

@Latentish
Copy link
Member

image
You have two disconnected pipes. I'm unsure if the "Wet floor" error is a hiccup with the components unrelated to your pr, or if there's an issue somewhere on the ship with a wet floor tile.

@Erikafox
Copy link
Contributor Author

Erikafox commented Dec 6, 2024

fixed, not caused by me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Map Change Tile placing is hard. Thank you for your service. Ship Ship successfully tested.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants