draw segments in two strokes #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkyle35242
requested review from
jkhusanov,
calebmackdavenport,
chaceburnette,
joshuakg,
rykugur,
kathrynnlester and
taylorcore
as code owners
rkyle35242
commented
May 2, 2024
| 0, | ||
| sweepFlag, | ||
| midPoint.x, | ||
| midPoint.y, |
There was a problem hiding this comment.
Lines 21-28 are the new entries to the path
chaceburnette
approved these changes
May 2, 2024
calebmackdavenport
approved these changes
May 2, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supporting variable arc sizes has revealed an issue with single-segment arcs when the total arc is 360 degrees. The starting and ending points for the drawn arc are the same, resulting in nothing being drawn. My proposed solution is to draw from the arc's starting point to a mid point then to the end point. This resolves the issue with no additional configuration needed or impact to the current experience.