Support custom start #81
Conversation
rkyle35242
commented
Apr 25, 2024
•
rkyle35242
commented
| Before | After (angleStart = 90) |
|---|---|
 |
 |
rkyle35242
requested review from
jkhusanov,
calebmackdavenport,
chaceburnette,
joshuakg,
rykugur,
kathrynnlester and
taylorcore
as code owners
| @@ -41,7 +42,7 @@ export const SegmentedArc = ({ | |||
| const totalSpacing = totalSpaces * spaceBetweenSegments; | |||
|
|
|||
| const arcSegmentDegree = (arcDegree - totalSpacing) / totalArcs; | |||
| const arcsStart = 90 - arcDegree / 2; | |||
| const arcsStart = angleStart || 90 - arcDegree / 2; | |||
There was a problem hiding this comment.
Think it's worth documenting any guidance on realistic values here? Or does it feel pretty obvious. Code makes sense, just thinking aloud
There was a problem hiding this comment.
I don't think there is an unrealistic value. Starting at 720 would just effectively be 0, since the value represents degrees.
There was a problem hiding this comment.
Example of 720 angleStart:
There was a problem hiding this comment.
What do you think about arcStartDegree? Also, would you be able to update docs too along with the previously added arcDegreeScale property? Could be done separately. https://github.com/shipt/segmented-arc-for-react-native?tab=readme-ov-file#-props
This reverts commit 4b688c1.
| "animationDuration": 1000, | ||
| "arcAnimatedValue": 0, | ||
| "arcSegmentDegree": 43.5, | ||
| "arcsStart": 420, |
|
I'm actually going to close this. The use case I had in mind is no longer valid and this doesn't work in all cases that I'd like it to. That being said, I will take some time to update the README to support the new scale property for segments |
