#49: Missing links in data for streams list

src/main/java/io/github/shinusuresh/productsup/client/domain/streams/Data.java

@@ -1,9 +1,16 @@
 package io.github.shinusuresh.productsup.client.domain.streams;
 
 import java.util.List;
+import java.util.SortedMap;
 
 /**
  * Data object that maps stream response.
+ *
+ * @param data  - Stream data.
+ * @param links - Links for pagination.
  */
-public record Data(List<Stream> data) {
+public record Data(
+    List<Stream> data,
+    SortedMap<String, String> links
+) {
 }

src/main/java/io/github/shinusuresh/productsup/client/domain/streams/Stream.java

@@ -2,21 +2,16 @@
 
 import com.fasterxml.jackson.annotation.JsonInclude;
 
-import java.util.List;
-import java.util.SortedMap;
-
 /**
  * Stream response.
  *
  * @param id - Stream id.
  * @param type - Stream type - chunked or referenced
  * @param attributes - Stream attributes
- * @param links - Links
  */
 @JsonInclude(JsonInclude.Include.NON_NULL)
 public record Stream(String id,
                      String type,
                      StreamAttributes attributes,
-                     Relationships relationships,
-                     List<SortedMap<String, String>> links) {
+                     Relationships relationships) {
 }

src/test/java/io/github/shinusuresh/productsup/client/StreamManagementApiClientTest.java

@@ -21,6 +21,7 @@
 import io.github.shinusuresh.productsup.client.domain.streams.upload.BatchStageStatus;
 import io.github.shinusuresh.productsup.client.domain.streams.upload.UploadAttributes;
 import java.util.Map;
+import org.junit.jupiter.api.DisplayName;
 import org.junit.jupiter.api.Test;
 import org.mockserver.client.MockServerClient;
 import org.mockserver.junit.jupiter.MockServerSettings;
@@ -72,13 +73,18 @@ void testListStreams() {
             .returns(StreamType.CHUNKED, from((val) -> val.attributes().type()))
             .returns("some_string_value", from((val) -> val.relationships().account().accountData().id()))
             .returns("account", from((val) -> val.relationships().account().accountData().type()));
+    }
 
+    @Test
+    @DisplayName("Issue #49")
+    void testListStreamsLinks() {
+        assertThat(streamApiClient.listStreams().links()).isNotNull();
     }
 
     @Test
     void testSuccessCreateStreams() {
         var data = new CreateStream(new Stream(null, "stream",
-            new StreamAttributes("Test Stream", StreamType.CHUNKED, null, null), null, null));
+            new StreamAttributes("Test Stream", StreamType.CHUNKED, null, null), null));
         var createStreamResponse = streamApiClient.createStream(data);
         assertThat(createStreamResponse.data().id()).isEqualTo("some_string_value");
     }
@@ -91,7 +97,7 @@ void removeStream() {
     @Test
     void testUpdateStream() {
         var updateStreamRequest = new UpdateStream(new Stream("123", "stream",
-            new StreamAttributes("Product data stream", null, null, null), null, null));
+            new StreamAttributes("Product data stream", null, null, null), null));
         var updateStreamResponse = streamApiClient.updateStream("83543218", updateStreamRequest);
         assertThat(updateStreamResponse.data())
             .extracting(Stream::id, Stream::type,
@@ -147,7 +153,7 @@ void testFailCreateStreams() {
                     """
                 )));
         var data = new CreateStream(new Stream(null, "stream",
-            new StreamAttributes("Test error Stream", StreamType.CHUNKED, null, null), null, null));
+            new StreamAttributes("Test error Stream", StreamType.CHUNKED, null, null), null));
 
         var exception = assertThrows(WebClientResponseException.class, () -> streamApiClient.createStream(data));
         var errors = exception.getResponseBodyAs(StreamErrors.class);