Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multistream を削除 #40

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Conversation

torikizi
Copy link
Contributor

マルチストリームオプションを削除しました。
ローカルビルドを実行して、Sora の設定を利用するように変更されていることを確認しました。
合わせてドキュメントの方も削除しています。


This pull request focuses on removing the multistream option from various parts of the codebase, including documentation and implementation files. The most important changes include updates to the documentation, removal of the multistream option from the command-line interface, and corresponding changes in the configuration and implementation files.

Documentation Updates:

  • Removed the multistream option from CHANGES.md, README.md, and several sections in doc/USE.md. [1] [2] [3] [4] [5] [6] [7]

Command-Line Interface:

  • Removed the --sora-multistream option from src/util.cpp. [1] [2]

Configuration and Implementation:

  • Removed the multistream field from ZakuroConfig in src/zakuro.h and updated its usage in src/zakuro.cpp. [1] [2]

@torikizi torikizi requested a review from miosakuma September 25, 2024 13:09
Copy link
Contributor

@miosakuma miosakuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

未指定に変更していることを確認しました、対応ありがとうございます!

@torikizi
Copy link
Contributor Author

レビューありがとうございます。こちらマージします。

@torikizi torikizi merged commit ac5a5d4 into develop Sep 25, 2024
6 checks passed
@torikizi torikizi deleted the feature/delete-multistream-option branch September 25, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants