minimumTranscribedTime と minimumConfidenceScore の両方が無効に設定されている場合はフィルタリングしない結果を返す #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voluntas
reviewed
Dec 27, 2024
| minimumConfidenceScore := config.MinimumConfidenceScore | ||
|
|
||
| // 両方無効の場合には全てのメッセージを返す | ||
| if (minimumTranscribedTime <= 0) && (minimumConfidenceScore <= 0) { |
voluntas
reviewed
Dec 27, 2024
voluntas
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the Amazon Transcribe handler to modify the behavior when both
minimum_confidence_scoreandminimum_transcribed_timeare set to zero. Additionally, it updates related test cases to ensure proper functionality.Changes to Amazon Transcribe handler:
amazon_transcribe_handler.go: Updated thebuildMessagefunction to return all messages when bothminimum_confidence_scoreandminimum_transcribed_timeare set to zero.Updates to test cases:
amazon_transcribe_handler_test.go: Added a new test case to verify the behavior when bothminimum_confidence_scoreandminimum_transcribed_timeare set to zero.amazon_transcribe_handler_test.go: Updated existing test cases to includeminimum_confidence_scoreandminimum_transcribed_timeconfigurations. [1] [2] [3] [4] [5]Documentation update:
CHANGES.md: Documented the change in behavior for Amazon Transcribe when bothminimum_confidence_scoreandminimum_transcribed_timeare set to zero.