Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

リトライの条件にサーバからの切断を追加する #195

Merged
merged 2 commits into from
Dec 24, 2024

Conversation

Hexa
Copy link
Contributor

@Hexa Hexa commented Dec 23, 2024

This pull request includes changes to improve the handling of server disconnections in the Amazon Transcribe service and updates to the GitHub Actions configuration.

Handling server disconnections:

  • amazon_transcribe_handler.go: Added logic to retry the connection if the server sends a GOAWAY frame and closes the connection. This change ensures that the service attempts to reconnect when the server disconnects unexpectedly.
  • amazon_transcribe_handler.go: Imported the strings package to facilitate the new logic for handling server disconnections.

Configuration updates:

  • CHANGES.md: Documented the change to retry connections when disconnected from the server, specifically for Amazon Transcribe.
  • CHANGES.md: Updated the GitHub Actions configuration to use ubuntu-24.04 instead of ubuntu-latest.

@Hexa Hexa requested a review from voluntas December 23, 2024 06:27
@Hexa Hexa merged commit 989b18d into develop Dec 24, 2024
1 check passed
@Hexa Hexa deleted the feature/add-retry-condition branch December 24, 2024 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants