Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

音声コーディックの E2E テストを追加する #553

Merged
merged 5 commits into from
Sep 6, 2024
Merged

音声コーディックの E2E テストを追加する #553

merged 5 commits into from
Sep 6, 2024
+216 −0

Conversation

blaue-fuchs
Copy link
Contributor

変更履歴

  • sendonly_audio_codec のサンプルを追加した
  • sendonly_audio_codec の E2E テストを追加した

@blaue-fuchs blaue-fuchs self-assigned this Sep 6, 2024
@blaue-fuchs blaue-fuchs marked this pull request as ready for review September 6, 2024 08:28
voluntas
voluntas approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@voluntas voluntas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1点だけ、タイポがあったので。

次は audio_bit_rate と codec のテストを結合して sendonly_audio としてください。

@blaue-fuchs blaue-fuchs merged commit 51e8785 into develop Sep 6, 2024
7 checks passed
@blaue-fuchs blaue-fuchs deleted the feature/add-e2e-test-audio-codec branch September 6, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@voluntas voluntas voluntas approved these changes

Assignees

@blaue-fuchs blaue-fuchs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blaue-fuchs @voluntas