Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libwebrtc に含まれるバージョン文字列を Android と揃える #193

Merged
merged 3 commits into from
Apr 16, 2024
Merged

libwebrtc に含まれるバージョン文字列を Android と揃える #193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6f63638
`libwebrtc` に含まれるバージョン文字列を Android と揃える
miosakuma Apr 1, 2024
4ae0fda
String の記述を省く
miosakuma Apr 16, 2024
8b4949e
変数名の見直し
miosakuma Apr 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@

## develop

- [CHANGE] シグナリング `connect` メッセージの `libwebrtc` に含まれるバージョン文字列を Android と揃える
- branch-heads を追加する
- () 内の libwebrtc バージョンについて最初の 1 文字を削る
- 送信される文字列は `Shiguredo-build M122 (M122.1.0 6b419a0)` から、`Shiguredo-build M122 (122.6261.1.0 6b419a0)` に変更される
- [UPDATE] WebRTC m122.6261.1.0 に上げる
- @miosakuma

Expand Down
3 changes: 3 additions & 0 deletions Sora/PackageInfo.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ public enum WebRTCInfo {
/// WebRTC フレームワークのソースコードのリビジョン
public static let revision = "6b419a0536b1a0ccfff3682f997c6f19bcbd9bd8"

/// WebRTC の branch-heads
public static let branch = "6261"

/// WebRTC フレームワークのソースコードのリビジョン (短縮版)
public static var shortRevision: String {
String(revision[revision.startIndex ..< revision.index(
Expand Down
2 changes: 1 addition & 1 deletion Sora/PeerChannel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,7 @@ class PeerChannel: NSObject, RTCPeerConnectionDelegate {

let soraClient = "Sora iOS SDK \(SDKInfo.version)"

let webRTCVersion = "Shiguredo-build \(WebRTCInfo.version) (\(WebRTCInfo.version).\(WebRTCInfo.commitPosition).\(WebRTCInfo.maintenanceVersion) \(WebRTCInfo.shortRevision))"
let webRTCVersion = "Shiguredo-build \(WebRTCInfo.version) (\(WebRTCInfo.version.dropFirst()).\(WebRTCInfo.branch).\(WebRTCInfo.commitPosition).\(WebRTCInfo.maintenanceVersion) \(WebRTCInfo.shortRevision))"

let simulcast = configuration.simulcastEnabled
let connect = SignalingConnect(
Expand Down