Skip to content

Commit

Permalink
Merge pull request #193 from shiguredo/feature/fix-signaling-libwebrt…
Browse files Browse the repository at this point in the history
…c-message

`libwebrtc` に含まれるバージョン文字列を Android と揃える
  • Loading branch information
miosakuma authored Apr 16, 2024
2 parents 6f005e3 + 8b4949e commit b2c2363
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 1 deletion.
4 changes: 4 additions & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@

## develop

- [CHANGE] シグナリング `connect` メッセージの `libwebrtc` に含まれるバージョン文字列を Android と揃える
- branch-heads を追加する
- () 内の libwebrtc バージョンについて最初の 1 文字を削る
- 送信される文字列は `Shiguredo-build M122 (M122.1.0 6b419a0)` から、`Shiguredo-build M122 (122.6261.1.0 6b419a0)` に変更される
- [UPDATE] WebRTC m122.6261.1.0 に上げる
- @miosakuma

Expand Down
3 changes: 3 additions & 0 deletions Sora/PackageInfo.swift
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ public enum WebRTCInfo {
/// WebRTC フレームワークのソースコードのリビジョン
public static let revision = "6b419a0536b1a0ccfff3682f997c6f19bcbd9bd8"

/// WebRTC の branch-heads
public static let branch = "6261"

/// WebRTC フレームワークのソースコードのリビジョン (短縮版)
public static var shortRevision: String {
String(revision[revision.startIndex ..< revision.index(
Expand Down
2 changes: 1 addition & 1 deletion Sora/PeerChannel.swift
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,7 @@ class PeerChannel: NSObject, RTCPeerConnectionDelegate {

let soraClient = "Sora iOS SDK \(SDKInfo.version)"

let webRTCVersion = "Shiguredo-build \(WebRTCInfo.version) (\(WebRTCInfo.version).\(WebRTCInfo.commitPosition).\(WebRTCInfo.maintenanceVersion) \(WebRTCInfo.shortRevision))"
let webRTCVersion = "Shiguredo-build \(WebRTCInfo.version) (\(WebRTCInfo.version.dropFirst()).\(WebRTCInfo.branch).\(WebRTCInfo.commitPosition).\(WebRTCInfo.maintenanceVersion) \(WebRTCInfo.shortRevision))"

let simulcast = configuration.simulcastEnabled
let connect = SignalingConnect(
Expand Down

0 comments on commit b2c2363

Please sign in to comment.