Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WEBRTC_BUILD_VERSION を m132.6834.4.0 に上げる #149

Merged
merged 4 commits into from
Dec 26, 2024

Conversation

torikizi
Copy link
Contributor

@torikizi torikizi commented Dec 25, 2024

  • m132.6834.4.0 にアップデート
  • ExportKeyingMaterial の廃止に対応
  • requested_resolution が scale_resolution_down_to になった修正に追従

This pull request includes updates to the WebRTC build version, changes to keying material export functions, and renaming of parameters related to resolution scaling in the codebase. The most important changes are summarized below:

Version Updates:

  • Updated WebRTC build version from m131.6778.4.0 to m132.6834.4.0 in CHANGES.md, VERSION, and examples/VERSION files. [1] [2] [3]

Keying Material Export:

  • Replaced ExportKeyingMaterial with ExportSrtpKeyingMaterial in srtp_keying_material_exporter.cpp due to deprecation. Added compatibility handling as ExportSrtpKeyingMaterial only accepts one argument compared to six in the previous function.

Resolution Scaling:

  • Renamed requested_resolution to scale_resolution_down_to in sora_signaling.cpp to reflect updated parameter naming conventions. [1] [2]

@torikizi torikizi changed the title ]WIP [WIP] WEBRTC_BUILD_VERSION を m132.6834.4.0 に上げる Dec 25, 2024
@torikizi torikizi changed the title [WIP] WEBRTC_BUILD_VERSION を m132.6834.4.0 に上げる WEBRTC_BUILD_VERSION を m132.6834.4.0 に上げる Dec 25, 2024
@torikizi torikizi requested review from melpon and miosakuma December 25, 2024 08:08
Copy link
Contributor

@melpon melpon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

よさそう

@torikizi
Copy link
Contributor Author

レビューありがとうございます。こちらマージします。

@torikizi torikizi merged commit 0a43463 into develop Dec 26, 2024
10 checks passed
@torikizi torikizi deleted the feature/update-webrtc-m132.6834.4.0 branch December 26, 2024 01:51
@torikizi torikizi removed the request for review from miosakuma December 26, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants