OnWsClose を SoraSignalingObserver に追加する #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnoho
changed the title
melpon
reviewed
Sep 26, 2024
include/sora/sora_signaling.h
Outdated
| @@ -226,6 +227,7 @@ class SoraSignaling : public std::enable_shared_from_this<SoraSignaling>, | |||
| void SendOnSignalingMessage(SoraSignalingType type, | |||
| SoraSignalingDirection direction, | |||
| std::string message); | |||
| void SendOnWsClose(boost::beast::websocket::close_reason& reason); | |||
src/sora_signaling.cpp
Outdated
| @@ -705,6 +707,7 @@ void SoraSignaling::DoInternalDisconnect( | |||
| bool ec_error = ec != boost::beast::websocket::error::closed; | |||
| if (ec_error) { | |||
| auto reason = self->ws_->reason(); | |||
| self->SendOnWsClose(reason); | |||
There was a problem hiding this comment.
ここだと非エラーの時に SendOnWsClose が呼ばれなさそうな気がします
src/sora_signaling.cpp
Outdated
| void SoraSignaling::SendOnWsClose( | ||
| boost::beast::websocket::close_reason& reason) { | ||
| if (auto ob = config_.observer.lock(); ob) { | ||
| ob->OnWsClose(reason.code, std::string(reason.reason.c_str())); |
|
@melpon ありがとうございます。いただいたレビューをもとに修正しました。再度ご確認いただければと思います。 |
|
ありがとうございます！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebSocket が閉じられた時の code と reason を取得できるよう OnWsClose を SoraSignalingObserver に追加します