-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[doc] サンプルのビルドは main かタグを利用してもらう #106
Conversation
examples/sumomo/README.md
Outdated
```shell | ||
$ git clone https://github.com/shiguredo/sora-cpp-sdk.git | ||
git clone -b main https://github.com/shiguredo/sora-cpp-sdk.git | ||
$ cd sora-cpp-sdk/examples |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
全体的に $
を消すならこの行も $
を消しておく必要がありそう
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@miosakuma
(melpon さんの指摘が修正されたら) LGTM です
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@torikizi 大丈夫です、対応ありがとうございます!
確認ありがとうございます。CI が通った後マージします。 |
CI 通りましたのでマージします。ありがとうございました。 |
develop ブランチをサンプルビルドすると失敗することがあるので main またはタグを利用してもらうように追記をしました。