Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] サンプルのビルドは main かタグを利用してもらう #106

Merged
merged 3 commits into from
Jun 27, 2024

Conversation

miosakuma
Copy link
Contributor

develop ブランチをサンプルビルドすると失敗することがあるので main またはタグを利用してもらうように追記をしました。

@miosakuma miosakuma requested a review from enm10k May 20, 2024 07:55
```shell
$ git clone https://github.com/shiguredo/sora-cpp-sdk.git
git clone -b main https://github.com/shiguredo/sora-cpp-sdk.git
$ cd sora-cpp-sdk/examples
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

全体的に $ を消すならこの行も $ を消しておく必要がありそう

Copy link
Contributor

@enm10k enm10k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miosakuma
(melpon さんの指摘が修正されたら) LGTM です

Copy link
Contributor Author

@miosakuma miosakuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@torikizi 大丈夫です、対応ありがとうございます!

@torikizi
Copy link
Contributor

確認ありがとうございます。CI が通った後マージします。

@torikizi
Copy link
Contributor

CI 通りましたのでマージします。ありがとうございました。

@torikizi torikizi merged commit 150308f into develop Jun 27, 2024
9 checks passed
@torikizi torikizi deleted the feature/fix-doc-to-build-master-branch branch June 27, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants