Skip to content

Commit

Permalink
sumomo に --simulcast-multicodec オプションを追加
Browse files Browse the repository at this point in the history
  • Loading branch information
melpon committed Apr 18, 2024
1 parent 056cd22 commit a9057f5
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 0 deletions.
3 changes: 3 additions & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@

## develop

- [ADD] sumomo に --simulcast-multicodec オプションを追加
- @melpon

## 2024.6.0 (2024-04-01)

- [CHANGE] `VplVideoDecoderImpl``ImplementationName``oneVPL` から `libvpl` に変更する
Expand Down
4 changes: 4 additions & 0 deletions examples/sumomo/src/sumomo.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ struct MomoSampleConfig {
boost::optional<bool> spotlight;
int spotlight_number = 0;
boost::optional<bool> simulcast;
boost::optional<bool> simulcast_multicodec;
boost::optional<bool> data_channel_signaling;
boost::optional<bool> ignore_disconnect_websocket;

Expand Down Expand Up @@ -142,6 +143,7 @@ class MomoSample : public std::enable_shared_from_this<MomoSample>,
config.spotlight = config_.spotlight;
config.spotlight_number = config_.spotlight_number;
config.simulcast = config_.simulcast;
config.simulcast_multicodec = config_.simulcast_multicodec;
config.data_channel_signaling = config_.data_channel_signaling;
config.ignore_disconnect_websocket = config_.ignore_disconnect_websocket;
config.proxy_agent = "Momo Sample for Sora C++ SDK";
Expand Down Expand Up @@ -375,6 +377,8 @@ int main(int argc, char* argv[]) {
->check(CLI::Range(0, 8));
add_optional_bool(app, "--simulcast", config.simulcast,
"Use simulcast (default: none)");
add_optional_bool(app, "--simulcast-multicodec", config.simulcast_multicodec,
"Use simulcast multi-codec (default: none)");
add_optional_bool(app, "--data-channel-signaling",
config.data_channel_signaling,
"Use DataChannel for Sora signaling (default: none)");
Expand Down
1 change: 1 addition & 0 deletions include/sora/sora_signaling.h
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ struct SoraSignalingConfig {
std::string spotlight_focus_rid;
std::string spotlight_unfocus_rid;
boost::optional<bool> simulcast;
boost::optional<bool> simulcast_multicodec;
std::string simulcast_rid;
boost::optional<bool> data_channel_signaling;
int data_channel_signaling_timeout = 180;
Expand Down
4 changes: 4 additions & 0 deletions src/sora_signaling.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -265,6 +265,10 @@ void SoraSignaling::DoSendConnect(bool redirect) {
m["simulcast"] = *config_.simulcast;
}

if (config_.simulcast_multicodec) {
m["simulcast_multicodec"] = *config_.simulcast_multicodec;
}

if (!config_.simulcast_rid.empty()) {
m["simulcast_rid"] = config_.simulcast_rid;
}
Expand Down

0 comments on commit a9057f5

Please sign in to comment.