-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5GB を超えるファイルのアップロード帯域制限に対応する #50
Conversation
n, err := s3Client.PutObject(ctx, osConfig.BucketName, dst, fileReader, fileSize, | ||
minio.PutObjectOptions{ContentType: "application/octet-stream", DisableMultipart: true}) | ||
minio.PutObjectOptions{ContentType: "application/octet-stream", NumThreads: 1}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
変更履歴だけ。あとは ok です。
…into feature/large-file-bandwidth-limitation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CHANGES の文言だけで、他は LGTM です
マージします |
変更履歴
This pull request includes changes to implement bandwidth throttling for large file uploads and updates to dependencies. The most important changes include adding bandwidth throttling for files over 5GB and updating the CI and Go versions.
Bandwidth Throttling for Large File Uploads:
CHANGES.md
: Added a change log entry describing the implementation of bandwidth throttling for files over 5GB by enabling multipart uploads with a single thread.s3.go
: Modified theuploadWebMFileWithRateLimit
function to set theNumThreads
option to 1 for multipart uploads when bandwidth is limited.Dependency Updates:
CHANGES.md
: Updated the CI staticcheck to version 2024.1.1 and Go to version 1.23.2.