Set return type of Volume::save() to boolean

shermp · Apr 28, 2024 · 4720efd · 4720efd
1 parent 159e4a5
commit 4720efd
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/ndb/NDBMetadata.cc b/src/ndb/NDBMetadata.cc
@@ -195,9 +195,9 @@ Result NDBMetadata::setMetadata(QString const& cID, QVariantMap md) {
         NDB_ASSERT(TypeError, validType, "Unexpected type for key %s", key.toUtf8().constData());
         symbols.Volume__setAttribute(v, key, val);
     }
-    int res = symbols.Volume__save(v, device);
+    bool res = symbols.Volume__save(v, device);
     NDB_ASSERT(MetadataError, res, "error saving metadata for id %s", cID.toUtf8().constData());
-    NDB_DEBUG("Volume__save returned with val %d", res);
+    NDB_DEBUG("Volume__save returned with val '%s'", res ? "true" : "false");
     return Ok;
 }
 

diff --git a/src/ndb/NDBMetadata.h b/src/ndb/NDBMetadata.h
@@ -70,7 +70,7 @@ class NDBMetadata : public QObject {
             void           (*VolumeManager__forEach)(QString const& dbName, std::function<void(Volume /*const&*/ *v)> f);
             bool           (*Volume__isValid)(Volume* _this);
             QVariantMap    (*Volume__getDbValues)(Volume* volume);
-            int            (*Volume__save)(Volume* _this, Device* device);
+            bool           (*Volume__save)(Volume* _this, Device* device);
             void           (*Volume__setAttribute)(Volume* _this, QString const& key, QVariant const& val);
         } symbols;