fix(github): fix some errors in the github templates

sharvit · Dec 21, 2019 · e16ee2e · e16ee2e
1 parent 04402df
commit e16ee2e
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 17 deletions.
diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
@@ -1,6 +1,10 @@
 <!---
   Please read the contribution guide before sending your first commit:
    https://github.com/sharvit/generator-node-mdl/blob/master/contributing.md)
+
+  Describe your changes in detail
+  Why is this change required? What problem does it solve?
+  If it fixes an open issue, please link to the issue here.
 -->
 
 ## PR Type
@@ -18,11 +22,3 @@
 * [ ] CI related changes
 * [ ] Documentation content changes
 * [ ] Other… Please describe:
-
-## Description
-
-<!---
-  Describe your changes in detail
-  Why is this change required? What problem does it solve?
-  If it fixes an open issue, please link to the issue here.
--->
diff --git a/src/app/generators/github/templates/_github/pull_request_template.md b/src/app/generators/github/templates/_github/pull_request_template.md
@@ -1,6 +1,10 @@
 <!---
   Please read the contribution guide before sending your first commit:
    https://github.com/<%= githubUsername %>/<%= projectName %>/blob/master/contributing.md
+
+  Describe your changes in detail
+  Why is this change required? What problem does it solve?
+  If it fixes an open issue, please link to the issue here.
 -->
 
 ## PR Type
@@ -19,14 +23,6 @@
 * [ ] Documentation content changes
 * [ ] Other… Please describe:
 
-## Description
-
-<!---
-  Describe your changes in detail
-  Why is this change required? What problem does it solve?
-  If it fixes an open issue, please link to the issue here.
--->
-
 ## How Has This Been Tested?
 
 <!---

diff --git a/src/app/generators/github/templates/contributing.md b/src/app/generators/github/templates/contributing.md
@@ -83,7 +83,7 @@ git commit
 git push origin my-branch
 ```
 
-Open this project on [GitHub](https://github.com/sharvit/generator-node-mdl), then click “Compare & pull request”.
+Open this project on [GitHub](https://github.com/<%= githubUsername %>/<%= projectName %>), then click “Compare & pull request”.
 
 ## Help needed