-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ new ] Add support for Idris 2 programming language #3150
Conversation
9e7798f
to
44562f7
Compare
0c76381
to
12c583b
Compare
12c583b
to
5c936a4
Compare
Hi, thanks for this. It would be nice to get some indication of how popular Idris 2 is, to help us decide whether it meets our criteria for inclusion by default. |
Well, maybe some statistics from GitHub may help. There are ~1600 repositories using this language solely on GitHub, around 10000 issues and PRs in these projects, GitHub has its syntax highlighting for its comments (it also has strong requirements on language popularity). Well, this criterion is valid for popular languages in Sublime text editor, as far as I understand. Sublime is not supported by Idris (Idris language has interactive compiler and closely works with the editor, supporting only vim, emacs and vscode). Thus, sublime highlighting was created specially to be supported by Additionally, I dared to suggest to include Idris while formally not meeting this criterion because I checked some already added languages and they also did not meet it formally, thus I thought that it is not valid anymore.
Am I right that you suggest adding my syntax definitions here and here (interestingly, the second one seems to use |
5c936a4
to
15530cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idris (Idris language has interactive compiler and closely works with the editor, supporting only vim, emacs and vscode). Thus, sublime highlighting was created specially to be supported by
bat
/syntect
from scratch based on ideas from existing highlighting
Ah, good to know, thanks for the context.
Additionally, I dared to suggest to include Idris while formally not meeting this criterion because I checked some already added languages and they also did not meet it formally, thus I thought that it is not valid anymore.
We have indeed unofficially relaxed the requirements a bit since lazy loading of syntaxes was implemented, to reduce the startup cost of having many languages. (#2181)
Considering this, and that it was written especially for bat
and friends, then let's merge it 🎉
15530cb
to
09505b6
Compare
Head branch was pushed to by a user without write access
09505b6
to
d6cb3ba
Compare
Oh, seems I have unintentnially broken the merge process. I saw that auto-merge was not working seemingly because |
Idris 2 is a pretty big and well-known programming language among purely functional languages supporting dependent types. But it still lacks support by
bat
, and thus by other tools likedelta
andtypst
. I suggest to add support for it with this PR.