Merge pull request #1413 from sharetribe/clean-unused-vars-and-follow…

…-eslint-rules

Remove unintended Lodash usage, unspecified window-scope calls and unused vars

CHANGELOG.md

@@ -14,6 +14,8 @@ way to update this template, but currently, we follow a pattern:
 
 ## Upcoming version 2020-XX-XX
 
+- [fix] Remove unintended Lodash usage, unspecified window-scope calls and unused vars
+  [#1413](https://github.com/sharetribe/ftw-daily/pull/1413)
 - [add] Route-based code splitting. This is done against sharetribe-scripts v5.0.0 using Loadable
   components. Read more from the pull request.
   [#1411](https://github.com/sharetribe/ftw-daily/pull/1411)

src/app.node.test.js

@@ -3,11 +3,9 @@
  */
 
 import React from 'react';
-import ReactDOM from 'react-dom';
 import ReactDOMServer from 'react-dom/server';
-import { Helmet } from 'react-helmet-async';
 import forEach from 'lodash/forEach';
-import { ClientApp, ServerApp } from './app';
+import { ServerApp } from './app';
 import configureStore from './store';
 
 const render = (url, context) => {
@@ -56,7 +54,7 @@ describe('Application - node environment', () => {
     };
     forEach(urlRedirects, (redirectPath, url) => {
       const context = {};
-      const { body } = render(url, context);
+      render(url, context);
       expect(context.url).toEqual(redirectPath);
     });
   });
@@ -65,7 +63,7 @@ describe('Application - node environment', () => {
     const urlRedirects = { '/l': '/', '/u': '/' };
     forEach(urlRedirects, (redirectPath, url) => {
       const context = {};
-      const { body } = render(url, context);
+      render(url, context);
       expect(context.url).toEqual(redirectPath);
     });
   });

src/components/ManageListingCard/ManageListingCard.test.js

@@ -1,6 +1,6 @@
 import React from 'react';
 import { renderShallow } from '../../util/test-helpers';
-import { createUser, createOwnListing, fakeIntl } from '../../util/test-data';
+import { createOwnListing, fakeIntl } from '../../util/test-data';
 import { ManageListingCardComponent } from './ManageListingCard';
 
 const noop = () => null;

src/components/Map/DynamicGoogleMap.js

@@ -1,6 +1,5 @@
 import React, { Component } from 'react';
 import { number, object, shape, string } from 'prop-types';
-import classNames from 'classnames';
 import { circlePolyline } from '../../util/maps';
 import config from '../../config';
 
@@ -91,7 +90,7 @@ class DynamicGoogleMap extends Component {
             }
           : {};
 
-        const marker = new window.google.maps.Marker({
+        new window.google.maps.Marker({
           position: center,
           map: this.map,
           title: address,

src/components/NamedLink/NamedLink.test.js

@@ -1,5 +1,5 @@
 import React from 'react';
-import { renderShallow, renderDeep } from '../../util/test-helpers';
+import { renderDeep } from '../../util/test-helpers';
 import NamedLink, { NamedLinkComponent } from './NamedLink';
 
 describe('NamedLinkComponent', () => {

src/components/ResponsiveImage/ResponsiveImage.js

@@ -77,12 +77,11 @@ const ResponsiveImage = props => {
 
   const imgProps = {
     className: classes,
-    alt,
     srcSet,
     ...rest,
   };
 
-  return <img {...imgProps} />;
+  return <img alt={alt} {...imgProps} />;
 };
 
 ResponsiveImage.defaultProps = {

src/components/SearchMap/SearchMapWithGoogleMaps.js

@@ -1,7 +1,7 @@
 import React, { Component } from 'react';
 import ReactDOM from 'react-dom';
 import invariant from 'invariant';
-import { arrayOf, func, node, number, oneOfType, shape, string } from 'prop-types';
+import { arrayOf, func, number, oneOfType, shape, string } from 'prop-types';
 import isEqual from 'lodash/isEqual';
 import classNames from 'classnames';
 import { types as sdkTypes } from '../../util/sdkLoader';
@@ -152,7 +152,7 @@ class CustomOverlayView extends Component {
       ...getOffsetOverride(this.containerElement, this.props),
     };
     const layoutStyles = getLayoutStyles(mapCanvasProjection, offset, this.props);
-    _.assign(this.containerElement.style, layoutStyles);
+    Object.assign(this.containerElement.style, layoutStyles);
   }
 
   draw() {
@@ -515,19 +515,13 @@ class SearchMapWithGoogleMaps extends Component {
     const {
       id,
       className,
-      onMapLoad,
-      onMapMoveEnd,
-      center,
-      bounds,
-      zoom,
       listings,
       activeListingId,
       infoCardOpen,
       onListingClicked,
       mapComponentRefreshToken,
       onListingInfoCardClicked,
       createURLToListing,
-      ...rest
     } = this.props;
     return (
       <div

src/components/SearchResultsPanel/SearchResultsPanel.test.js

@@ -1,5 +1,4 @@
 import React from 'react';
-import { currencyConfig } from '../../util/test-data';
 import { fakeIntl } from '../../util/test-data';
 import { renderShallow } from '../../util/test-helpers';
 import SearchResultsPanel from './SearchResultsPanel';

src/containers/EditListingPage/EditListingPage.js

@@ -36,7 +36,6 @@ import {
   requestImageUpload,
   updateImageOrder,
   removeListingImage,
-  loadData,
   clearUpdatedTab,
   savePayoutDetails,
 } from './EditListingPage.duck';

src/containers/EditListingPage/EditListingPage.test.js

@@ -34,7 +34,6 @@ describe('EditListingPageComponent', () => {
         onUpdateListing={noop}
         onImageUpload={noop}
         onRemoveListingImage={noop}
-        onManageDisableScrolling={noop}
         onPayoutDetailsFormChange={noop}
         onPayoutDetailsSubmit={noop}
         onUpdateImageOrder={noop}

src/containers/InboxPage/InboxPage.test.js

@@ -1,5 +1,4 @@
 import React from 'react';
-import { RoutesProvider } from '../../components';
 import { renderShallow, renderDeep } from '../../util/test-helpers';
 import {
   fakeIntl,
@@ -9,7 +8,6 @@ import {
   createBooking,
 } from '../../util/test-data';
 import { InboxPageComponent, InboxItem, txState } from './InboxPage';
-import routeConfiguration from '../../routeConfiguration';
 import { TRANSITION_CONFIRM_PAYMENT } from '../../util/transaction';
 import { LINE_ITEM_NIGHT } from '../../util/types';
 

src/containers/LandingPage/LandingPage.test.js

@@ -2,8 +2,6 @@ import React from 'react';
 import { fakeIntl } from '../../util/test-data';
 import { renderShallow } from '../../util/test-helpers';
 import { LandingPageComponent } from './LandingPage';
-import { RoutesProvider } from '../../components';
-import routeConfiguration from '../../routeConfiguration';
 
 const noop = () => null;
 

src/containers/ListingPage/ListingPage.test.js

@@ -20,10 +20,6 @@ import {
 import { addMarketplaceEntities } from '../../ducks/marketplaceData.duck';
 import { showListingRequest, showListingError, showListing } from './ListingPage.duck';
 
-// routeConfiguration needs to be imported before tests for ListingPageComponent can be made.
-// Otherwise, ListingPage itself is not initialized correctly when routeConfiguration is imported
-// (loadData call fails).
-import routeConfiguration from '../../routeConfiguration';
 import { ListingPageComponent } from './ListingPage';
 import ActionBarMaybe from './ActionBarMaybe';
 

src/containers/ProfilePage/ProfilePage.test.js

@@ -3,8 +3,6 @@ import { renderShallow } from '../../util/test-helpers';
 import { createUser, fakeIntl, fakeViewport } from '../../util/test-data';
 import { ProfilePageComponent } from './ProfilePage';
 
-const noop = () => null;
-
 describe('ProfilePage', () => {
   it('matches snapshot', () => {
     const tree = renderShallow(

src/containers/SearchPage/SearchPage.test.js

@@ -1,19 +1,8 @@
 import React from 'react';
 import { renderShallow } from '../../util/test-helpers';
 import { fakeIntl } from '../../util/test-data';
-import { types as sdkTypes } from '../../util/sdkLoader';
 import { SearchPageComponent } from './SearchPage';
-import reducer, {
-  ADD_FILTER,
-  LOAD_LISTINGS,
-  addFilter,
-  callFetchListings,
-  initialState,
-  loadListings,
-  watchLoadListings,
-} from './SearchPage.duck';
 
-const { LatLng } = sdkTypes;
 const noop = () => null;
 
 describe('SearchPageComponent', () => {

src/default-location-searches.js

@@ -7,7 +7,7 @@ const { LatLng, LatLngBounds } = sdkTypes;
 //
 // Each item in the array should be an object with a unique `id` (String) and a
 // `predictionPlace` (util.types.place) properties.
-export default [
+const defaultLocations = [
   {
     id: 'default-helsinki',
     predictionPlace: {
@@ -44,3 +44,4 @@ export default [
     },
   },
 ];
+export default defaultLocations;