Remove extra = in sharedb-legacy devDependency #623
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the latest Node 18.17.1 with NPM 6, sharedb fails to install with an "Invalid URL" error.
I traced it back to an attempted parsing of
"npm:sharedb@=1.1.0"
, which is the specifier for the sharedb-legacy devDependency.According to node-semver:
It seems something in the combination of latest Node 18 with NPM 6 isn't stripping the
=
.Node 18 by default comes with NPM 9, which is why sharedb's CI didn't break. However, NPM 6 is still supported since NPM 7 made some notable breaking changes, and the
=
somehow breaks things even when sharedb is installed as a dependency.Since the
=
is meaningless in the specifier, removing it fixes the issue and shouldn't affect anything.Click to see full NPM stack trace