Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for doc.removeListener #160

Merged
merged 1 commit into from
Sep 15, 2017
Merged

Conversation

curran
Copy link
Contributor

@curran curran commented Jun 17, 2017

I faced a need to use this, as after invoking doc.destroy(), then invoking doc.subscribe from elsewhere, the listeners added before the call to doc.destroy() were still being invoked.

@coveralls
Copy link

coveralls commented Jun 17, 2017

Coverage Status

Coverage remained the same at 96.106% when pulling 4264655 on curran:patch-9 into 2384145 on share:master.

@curran
Copy link
Contributor Author

curran commented Jun 26, 2017

Relates to #147

@curran
Copy link
Contributor Author

curran commented Jul 19, 2017

@nateps @rkstedman This PR is ready for review.

Review delay possibly related to #163

@curran
Copy link
Contributor Author

curran commented Aug 1, 2017

@nateps @rkstedman @zag2art Any chance of reviewing/commenting on this PR? It should be quick to review and merge, it's only documentation changes.

@minicuper
Copy link
Contributor

minicuper commented Aug 1, 2017

Hey, it looks fine to me but I'm not in the org. Don't have write access.

@curran
Copy link
Contributor Author

curran commented Aug 1, 2017

@zag2art Thanks for taking a look!

@curran
Copy link
Contributor Author

curran commented Sep 14, 2017

@nateps Kindly requesting review and merge of this small PR that changes documentation only. Thanks!

@rkstedman rkstedman self-assigned this Sep 15, 2017
@rkstedman rkstedman merged commit 10a148b into share:master Sep 15, 2017
@curran
Copy link
Contributor Author

curran commented Sep 15, 2017

@rkstedman Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants