feat: don't refetch approval/stake fees when mutation is pending #6989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note, spotted another issue with share of pool being refetchy, see Jam at 2:39 https://jam.dev/c/eea90cea-e428-4c00-9400-d3151ac6e32b - fixed by cherry-picking this bit from the topmost PR: https://github.com/shapeshift/web/pull/6963/files#diff-2c26074bf0c6e9c74bfe83f94b8a5e575248d9f946d41508854d0c7868402135 0fd524e / https://jam.dev/c/40e91cd2-ead4-4597-9497-a13cf7b8fc56 |
gomesalexandre
commented
May 24, 2024
gomesalexandre
commented
May 24, 2024
3 tasks
0xApotheosis
approved these changes
May 27, 2024
gomesalexandre
added a commit
that referenced
this pull request
May 27, 2024
* feat: don't refetch approval/stake fees when mutation is pending * feat: cherry-pick invalidateQueries safety bits
gomesalexandre
added a commit
that referenced
this pull request
May 27, 2024
* feat: don't refetch approval/stake fees when mutation is pending * feat: cherry-pick invalidateQueries safety bits
0xApotheosis
pushed a commit
that referenced
this pull request
May 27, 2024
* feat: surface manual rune address to users, start wire-up of form in ChangeAddressInput and improve types * feat: cleanup * feat: new rune address terminology * feat: improve naming and validation from the skeleton pre-wire-up * feat: wire-up gas fees * feat: cleanup fluff * feat: more cleanup * feat: more cleanup * feat: disable same addy for custom addresses * feat: wire-up change address status * fix: loading state and improve copies * fix: lint * feat: invalidate queries * feat: consistently invalidate as an async cleanup operation * feat: tackle TODO * add empty state * update confirm and input change address * feat: account dropdown address form-based same address validation * feat: don't fetch fees on same account dropdown addy * feat: more guards against overfetching * feat: disable button when no current address * feat: omit undefined param in sendChangeAddressTx and rename to handleChangeAddress * feat: cleanup * feat: better home for types * feat: more cleanup * feat: comment typo * fix: merge * fix: error messaging * feat: don't refetch approval/stake fees when mutation is pending (#6989) * feat: don't refetch approval/stake fees when mutation is pending * feat: cherry-pick invalidateQueries safety bits * feat: changeAddresStatus external link * feat: improve copy * feat: rm unused translations * fix: address selection invalid shenanigans * feat: improve alignment --------- Co-authored-by: reallybeard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tackles the jumpy issue spotted by @0xApotheosis in #6925 (review):
Pull Request Type
Issue (if applicable)
Risk
Testing
Engineering
Operations
Screenshots (if applicable)
https://jam.dev/c/eea90cea-e428-4c00-9400-d3151ac6e32b