Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enable wallet connect in mobile #3001

Merged
merged 1 commit into from
Oct 6, 2022
Merged

fix: enable wallet connect in mobile #3001

merged 1 commit into from
Oct 6, 2022

Conversation

asamere
Copy link
Contributor

@asamere asamere commented Oct 6, 2022

Description

Enable walletconnect for mobile

Notice

  • Have you followed the guidelines in our Contributing guide?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Pull Request Type

  • 🐛 Bug fix (Non-breaking Change: Fixes an issue)
  • 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • 💅 New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

shapeshift/mobile-app#47

Risk

Testing

Engineering

Operations

Screenshots (if applicable)

@asamere asamere requested review from 0xean and 0xdef1cafe October 6, 2022 16:47
@asamere asamere requested a review from a team as a code owner October 6, 2022 16:47
@asamere asamere linked an issue Oct 6, 2022 that may be closed by this pull request
Switching Wallets from WalletConnect to another wallet should correctly end the wallet connect session #2740
Closed
0xean
0xean approved these changes Oct 6, 2022
View reviewed changes
Copy link
Contributor

@0xean 0xean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should merge to develop so we can test there.

@0xdef1cafe 0xdef1cafe merged commit 88acae4 into develop Oct 6, 2022
@0xdef1cafe 0xdef1cafe deleted the fix-mobile-walletconnect branch October 6, 2022 19:23
@0xdef1cafe 0xdef1cafe mentioned this pull request Oct 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xean 0xean 0xean approved these changes

@con5cience con5cience con5cience approved these changes

@0xdef1cafe 0xdef1cafe Awaiting requested review from 0xdef1cafe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switching Wallets from WalletConnect to another wallet should correctly end the wallet connect session
4 participants
@asamere @con5cience @0xean @0xdef1cafe