-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: hot wallet cli #74
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaladinlight
force-pushed
the
hot-wallet-cli-part-1
branch
2 times, most recently
from
June 20, 2024 21:44
f1ec2ab
to
031f972
Compare
kaladinlight
force-pushed
the
hot-wallet-cli-part-1
branch
from
June 20, 2024 21:45
031f972
to
94957b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass, untested but conceptually looks sane to me!
This was
linked to
issues
Jul 8, 2024
0xean
approved these changes
Jul 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of comments, nothing really blocking, just questions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #69
Create and Fund:
Recover from keystore file:
Recover from custom keystore file:
Recover from manual mnemonic:
Fail to recover:
Testing steps:
Add
break
tosignTransactions
and/orbroadcastTransactions
loops to simulate a non complete sign or broadcast step and validate script picks up properly. Known issue is the balance check inwallet.fund()
that is only valid on initial fund, but will fail when trying to pick up after 1 or more txs have been broadcast. Also known issue is we broadcast too fast currently resulting in invalid nonce errorsNO NEED TO TEST MULTISIG DOCS (unrelated to script, will be validated manually outside of these PRs)
index.ts
unsignedTx_epoch-N.json
file to manually fund the hot wallet from a wallet that you control (doesn't have to be multisig). Be sure to use the correct amount to send for funding and you can add the same memo if desired, but has no affect on the script itself