chore: allow use of localhost in simulator #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gomesalexandre
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
Confirmed this does what it says on the box!
Main
https://jam.dev/c/0d2e6aa2-6981-4ad9-866f-e10fdc6dacc6
This diff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the use of localhost when running a simulated app build.
shouldLoadFilterwas ignoringlocalhostso we just ended up with the browser version whenever we tried to connect to the local port.Localhost env in device simulator now happy.
localhost.mp4