Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common): remove unused packages #664

Closed
wants to merge 42 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
f4e7af0
Native work
BitHighlander Jan 12, 2024
786ac76
KeepKey working
BitHighlander Jan 24, 2024
9fd87cc
KeepKey integration tests
BitHighlander Jan 24, 2024
82cfb68
sigs
BitHighlander Jan 24, 2024
28e7665
uncomment
BitHighlander Jan 24, 2024
49e9a9c
new txs and sigs
BitHighlander Jan 30, 2024
d3b80d7
Merge branch 'master' of https://github.com/shapeshift/hdwallet into …
BitHighlander Jan 30, 2024
f638ce7
clean up tests
BitHighlander Jan 30, 2024
908084b
Merge pull request #12 from keepkey/feature-maya-final
BitHighlander Jan 30, 2024
4974a65
feat(common): remove unused wallet adapters
pastaghost Jan 30, 2024
91bdd35
feat(sandbox): remove references to old packages
pastaghost Jan 30, 2024
d015f12
cleanup(integration): remove unused package references
pastaghost Jan 30, 2024
7d20d39
cleanup(hdwallet-native): remove unused package references
pastaghost Jan 30, 2024
fba5998
cleanup(hdwallet-core): remove unused package references
pastaghost Jan 30, 2024
3258e5c
cleanup(hdwallet-sandbox): remove unused portis app id
pastaghost Jan 30, 2024
d349149
cleanup(common): remove unused package references
pastaghost Jan 30, 2024
c885341
cleanup(common): remove unused package references
pastaghost Jan 30, 2024
8c0d7e7
chore(sandbox): update package namespaces
pastaghost Feb 12, 2024
73b2a38
chore(integration): update package namespaces
pastaghost Feb 12, 2024
7a36ec0
chore(core): update package namespaces
pastaghost Feb 12, 2024
7825c81
chore(keepkey): update package namespaces
pastaghost Feb 12, 2024
1a23d54
chore(native): update package namespaces
pastaghost Feb 12, 2024
95cb933
fix(common): update README
pastaghost Feb 12, 2024
10e06cf
chore(common): update package namespaces
pastaghost Feb 12, 2024
18f74aa
chore(keepkey): update package namespaces
pastaghost Feb 12, 2024
c880547
chore(native): update package namespaces
pastaghost Feb 12, 2024
62d0a6d
chore(integration): update package namespaces
pastaghost Feb 12, 2024
534cc59
chore(sandbox): update package namespaces
pastaghost Feb 12, 2024
55ad56a
chore(common): update package namespaces
pastaghost Feb 12, 2024
2503792
chore(keepkey): update package versions
pastaghost Feb 12, 2024
7b49d45
chore(native): update package versions
pastaghost Feb 12, 2024
f463019
chore(core): update package versions
pastaghost Feb 12, 2024
9ce9b99
chore(sandbox): update package versions, upgrade parcel
pastaghost Feb 12, 2024
8341b01
chore(integration): update package versions, update package namespaces
pastaghost Feb 12, 2024
f9eafb6
chore(common): upgrade lerna
pastaghost Feb 12, 2024
34e895a
chore(common): update package namespaces
pastaghost Feb 12, 2024
b44bd96
chore(common): upgrade node
pastaghost Feb 12, 2024
cb1cb32
fix(sandbox): fix lint errors
pastaghost Feb 12, 2024
a28178f
fix(keepkey): remove unused import
pastaghost Feb 12, 2024
d7fdf41
fix(native): unskip osmosis test
pastaghost Feb 12, 2024
8db9cd0
fix(native): temporarily disable failing test
pastaghost Feb 12, 2024
b8a6693
chore(native): temporarily disable failing test
pastaghost Feb 12, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
16
20.11.0
36 changes: 10 additions & 26 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ Try it out [here](https://hdwallet.shapeshift.now.sh/)!

## Documentation

- [hdwallet](#hdwallet)
- [HDWallet](#hdwallet)
- [Documentation](#documentation)
- [Installation](#installation)
- [Importing Library](#importing-library)
Expand All @@ -23,25 +23,20 @@ Try it out [here](https://hdwallet.shapeshift.now.sh/)!
## Installation

```bash
yarn add @shapeshiftoss/hdwallet-core
yarn add @shapeshiftoss/hdwallet-keepkey-webusb
yarn add @shapeshiftoss/hdwallet-trezor-connect
yarn add @shapeshiftoss/hdwallet-ledger-webusb
yarn add @keepkey/hdwallet-core
yarn add @keepkey/hdwallet-keepkey-webusb
yarn add @keepkey/hdwallet-trezor-connect
yarn add @keepkey/hdwallet-ledger-webusb
```

## Importing Library

You can import the generated bundle to use each of the component libraries:

```javascript
import { HDWallet } from "@shapeshiftoss/hdwallet-core";
import { isKeepKey, KeepKeyHDWallet } from "@shapeshiftoss/hdwallet-keepkey";
import { isLedger, LedgerHDWallet } from "@shapeshiftoss/hdwallet-ledger";
import { isTrezor, TrezorHDWallet } from "@shapeshiftoss/hdwallet-trezor";

import { WebUSBKeepKeyAdapter } from "@shapeshiftoss/hdwallet-keepkey-webusb";
import { WebUSBLedgerAdapter } from "@shapeshiftoss/hdwallet-ledger-webusb";
import { TrezorAdapter } from "@shapeshiftoss/hdwallet-trezor-connect";
import { HDWallet } from "@keepkey/hdwallet-core";
import { isKeepKey, KeepKeyHDWallet } from "@keepkey/hdwallet-keepkey";
import { WebUSBKeepKeyAdapter } from "@keepkey/hdwallet-keepkey-webusb";
```

## Usage
Expand All @@ -50,28 +45,17 @@ The recommended way to use the library is through a `Keyring` singleton,
which manages connected devices:

```javascript
import { Keyring } from "@shapeshiftoss/hdwallet-core";
import { Keyring } from "@keepkey/hdwallet-core";
const keyring = new Keyring();
```

To add in support for a given wallet type, add in the relevant `Transport`
adapter by calling `useKeyring()` on it:

```javascript
import { WebUSBKeepKeyAdapter } from "@shapeshiftoss/hdwallet-keepkey-webusb";
import { TrezorAdapter } from "@shapeshiftoss/hdwallet-trezor-connect";
import { WebUSBKeepKeyAdapter } from "@keepkey/hdwallet-keepkey-webusb";

const keepkeyAdapter = WebUSBKeepKeyAdapter.useKeyring(keyring);

const trezorAdapter = TrezorAdapter.useKeyring(keyring, {
debug: false,
manifest: {
email: "[email protected]", // TrezorConnect info
appUrl: "https://example.com", // URL of hosted domain
},
});

const ledgerAdapter = LedgerAdapter.useKeyring(keyring);
```

After setting up a `Keyring`, and plugging various transport adapters into
Expand Down
19 changes: 0 additions & 19 deletions docs/architecture.dot
Original file line number Diff line number Diff line change
Expand Up @@ -30,24 +30,5 @@ digraph D {
hdwalletkeepkeychromeusb -> hdwalletkeepkey
}

subgraph cluster_2 {
label = "Trezor"

hdwallettrezor [label="hdwallet-trezor", shape=box]
hdwallettrezor -> hdwalletcore

hdwallettrezorconnect [label="hdwallet-trezor-connect", shape=box, fillcolor="darkseagreen1", style=filled]
hdwallettrezorconnect -> hdwallettrezor
}

subgraph cluster_3 {
label = "Ledger"

hdwalletledger [label="hdwallet-ledger", shape=box]
hdwalletledger -> hdwalletcore

hdwalletledgerwebusb [label="hdwallet-ledger-webusb", shape=box, fillcolor="darkseagreen1", style=filled]
hdwalletledgerwebusb -> hdwalletledger
}
}

36 changes: 13 additions & 23 deletions examples/sandbox/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -110,18 +110,7 @@ <h4>Select</h4>
<button id="keepkey">Pair KeepKey</button>
<button id="keepkeybridge">Pair KKBridge</button>
<button id="kkemu">Pair Emulator</button>
<button id="trezor">Pair Trezor</button>
<button id="ledgerwebusb">Pair Ledger (webUSB)</button>
<button id="ledgerwebhid">Pair Ledger (webHID)</button>
<button id="portis">Pair Portis</button>
<button id="native">Pair Native</button>
<button id="metaMask">Pair MetaMask</button>
<button id="xdefi">Pair XDEFI</button>
<button id="keplr">Pair Keplr</button>
<button id="tallyHo">Pair Tally Ho</button>
<button id="coinbase">Pair Coinbase</button>
<button id="walletConnect">Pair WalletConnect</button>
<button id="walletConnectV2">Pair WalletConnect V2</button>

<select id="keyring" style="height: 100px" size="4"></select>
</div>
Expand Down Expand Up @@ -159,15 +148,6 @@ <h4>Xpubs</h4>
<button class="button button-outline getXpubs coin-Ethereum">Ethereum</button>
<input type="text" class="xpubResults" />
</div>
<div class="container">
<h4>Ledger Device</h4>
<button class="button button-outline" id="openApp">Open App</button>
<input type="text" id="ledgerAppToOpen" />
<button class="button button-outline" id="validateApp">Validate Open App</button>
<input type="text" id="ledgerAppToValidate" />
<button class="button button-outline" id="getAppInfo">App Info</button>
<input type="text" id="appInfo" />
</div>
<div class="container">
<h4>Eos</h4>
<button class="button button-outline" id="eosAddr">Address</button>
Expand Down Expand Up @@ -227,7 +207,13 @@ <h4>Arkeo</h4>
<button class="button button-outline" id="arkeoAddClaim">Add Claim</button>
<input type="text" id="arkeoResults" />
</div>

<div class="container">
<h4>MAYAChain</h4>
<h5>Native MAYA</h5>
<button class="button button-outline" id="mayachainAddr">Address</button>
<button class="button button-outline" id="mayachainTx">Tx</button>
<input type="text" id="mayachainNativeResults" />
</div>
<div class="container">
<h4>THORChain</h4>
<h5>Native RUNE</h5>
Expand Down Expand Up @@ -305,8 +291,12 @@ <h4>Ethereum</h4>
<button class="button button-outline" id="ethSign">Sign Message</button>
<button class="button button-outline" id="ethVerify">Verify</button>
<button class="button button-outline" id="ethSignTypedData">Sign Typed Data (OpenSea Listing)</button>
<button class="button button-outline" id="ethSignTypedDataAlternate1">Sign Typed Data (primaryType is 80+ chars)</button>
<button class="button button-outline" id="ethSignTypedDataAlternate2">Sign Typed Data (primaryType is "EIP712Domain")</button>
<button class="button button-outline" id="ethSignTypedDataAlternate1">
Sign Typed Data (primaryType is 80+ chars)
</button>
<button class="button button-outline" id="ethSignTypedDataAlternate2">
Sign Typed Data (primaryType is "EIP712Domain")
</button>
<input type="text" id="ethResults" />
</div>
<div class="container">
Expand Down
Loading
Loading