feat: add hdwallet-metamask-shapeshift-multichain adapter #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
packages/hdwallet-metamask-shapeshift-multichain/src/binance.ts
Outdated
Show resolved
Hide resolved
packages/hdwallet-native/src/crypto/isolation/adapters/binance.ts
Outdated
Show resolved
Hide resolved
…rna to 5.2.0 bumping inquirer
This was referenced Aug 26, 2023
gomesalexandre
force-pushed
the
metamask-snaps-integration
branch
from
1bcb5ed to
1c7f34b
Compare
gomesalexandre
force-pushed
the
metamask-snaps-integration
branch
from
ac088b8 to
1d5cc91
Compare
gomesalexandre
approved these changes
Sep 27, 2023
kaladinlight
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disregard the below, this is now published as alpha: https://www.npmjs.com/package/@shapeshiftoss/metamask-snaps-adapter
Note, we had to bump tsc here to accomodate for the version in metamask-snaps monorepo (which we can't avoid because of new TS features from TS 4.4+ that need to be supported in some snaps transient dependencies), which subsequently broke a lot of things at type-level, explaining the disgusting amount of ts-ignores in this diff.
Opening draft to visualize the diffNote, both shapeshift/metamask-snaps#100, #628, and shapeshift/web#5166 assume verdaccio running on default port 4873, and all packages published there:
This is only for development purposes, and config should be reverted to default uplink before merging each of these PRs.