Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option for specifying model config in args directly, for programmatic use #3

Closed
wants to merge 2 commits into from
Closed

Added option for specifying model config in args directly, for programmatic use #3

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d26a576
Added option for specifying model config in args directly
shaltielshmid Jul 29, 2024
68230b3
Added comment explaining
shaltielshmid Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/lighteval/models/model_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,8 +312,13 @@ def create_model_config( # noqa: C901

return BaseModelConfig(**args_dict)

with open(args.model_config_path, "r") as f:
config = yaml.safe_load(f)["model"]
# This option isn't provided for use via the CLI but rather for programmatic use when constructing the config
# in code, so that the config won't need to be saved to a temp file when calling lighteval.
if hasattr(args, "model_config") and args.model_config:
config = args.model_config["model"]
else:
with open(args.model_config_path, "r") as f:
config = yaml.safe_load(f)["model"]

if config["type"] == "tgi":
return TGIModelConfig(
Expand Down
Loading