Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topic recognition #143

Open
wants to merge 14 commits into
base: topic-recognition
Choose a base branch
from

Conversation

FinnRobertson15
Copy link

This is a Triplet Siamese Classifier for the ADNI dataset to classifier Alzheimer's disease

@nathasha-naranpanawa
Copy link
Collaborator

This is an initial inspection, no action is required at this point

Difficulty: Hard

Readme: Poor

  • some information provided on the algorithm
  • some plots/figures provided with no context and minimal information
  • a triplet loss plot ir shown, but no plots for the classifier are presented
  • no discussion/interpretations on the results

Commit messages: OK, very few and very brief

Code:

  • minimal to no comments
  • design is ok

Functionality/Performance:

  • looking at the 2d manifold, the triplet doesn't seem to have learned anything at all(?)
  • classification accuracy is only 65%

General comments:

  • solves the problem apporpriately although performance is very poor

@shakes76
Copy link
Owner

shakes76 commented Nov 20, 2023

Marking

Good Practice (Design/Commenting, TF/Torch Usage)

Adequate design and implementation
Good spacing and comments
Header blocks missing -1

Recognition Problem

Solves problem, poor performance -1
Driver Script present
File structure present, but not in folder, may your own folder for project code -2
Shows Usage & Demo & Visualisation & Data usage, no classifier plot -1
Module present
Commenting minimal -1
No Data leakage
Difficulty: Hard

Commit Log

Meaningful commit messages
Progressive commits used

Documentation

ReadMe OK, no usage, no refs -2
Model/technical explanation, no architecture -1
Good Description and Comments
Markdown used and PDF submitted

Pull Request

Successful Pull Request (Working Algorithm Delivered on Time in Correct Branch)
Feedback required, move code into your own folder and restore repo README -2
Request Description minimal -1

@shakes76 shakes76 added the question Further information is requested label Nov 20, 2023
@shakes76
Copy link
Owner

Feedback marks possible +2 if the requested changes are made (see above).

@wangzhaomxy
Copy link
Collaborator

No feedback attempt and no feedback marks granted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested Siamese
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants