Merge pull request sxs-collaboration#5755 from nilsvu/find_paraview

Turn finding ParaView off by default
shabibti · Feb 12, 2024 · 70fcc77 · 70fcc77
2 parents 1a269eb + c136823
commit 70fcc77
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/cmake/SetupParaView.cmake b/cmake/SetupParaView.cmake
@@ -1,12 +1,14 @@
 # Distributed under the MIT License.
 # See LICENSE.txt for details.
 
-option(ENABLE_PARAVIEW "Try to find ParaView to enable 3D rendering tools" ON)
+option(ENABLE_PARAVIEW "Try to find ParaView to enable 3D rendering tools" OFF)
 
-if (ENABLE_PARAVIEW)
-  find_package(ParaView)
+if (NOT ENABLE_PARAVIEW)
+  return()
 endif()
 
+find_package(ParaView)
+
 # Help `find_python_module` find ParaView
 if (PARAVIEW_PYTHONPATH)
   set(PY_paraview_LOCATION ${PARAVIEW_PYTHONPATH}/paraview)

diff --git a/docs/DevGuide/BuildSystem.md b/docs/DevGuide/BuildSystem.md
@@ -245,7 +245,7 @@ cmake -D FLAG1=OPT1 ... -D FLAGN=OPTN <SPECTRE_ROOT>
     bindings and interpolating volume data files. Note that simulations do not
     typically use OpenMP parallelization, so this flag only applies to tools.
 - ENABLE_PARAVIEW
-  - Try to find ParaView to enable 3D rendering tools (default is `ON`)
+  - Try to find ParaView to enable 3D rendering tools (default is `OFF`)
 - ENABLE_PROFILING
   - Enables various options to make profiling SpECTRE easier
     (default is `OFF`)

diff --git a/support/Environments/caltech_hpc_gcc_icelake.sh b/support/Environments/caltech_hpc_gcc_icelake.sh
@@ -43,6 +43,7 @@ spectre_run_cmake() {
           -D MACHINE=CaltechHpcIcelake \
           -D OVERRIDE_ARCH=icelake-server \
           -D BLA_VENDOR=OpenBLAS \
+          -D ENABLE_PARAVIEW=ON \
           "$@" \
           $SPECTRE_HOME
 }
diff --git a/support/Environments/caltech_hpc_gcc_skylake.sh b/support/Environments/caltech_hpc_gcc_skylake.sh
@@ -42,6 +42,7 @@ spectre_run_cmake() {
           -D BUILD_PYTHON_BINDINGS=ON \
           -D MACHINE=CaltechHpcSkylake \
           -D OVERRIDE_ARCH=skylake \
+          -D ENABLE_PARAVIEW=ON \
           "$@" \
           $SPECTRE_HOME
 }